Dismiss a few other R# warnings

dahlbyk · nulltoken · commit 549a80c6c823 · 2013-02-14T07:47:37.000+01:00
diff --git a/LibGit2Sharp.Tests/TestHelpers/ExpectedFetchState.cs b/LibGit2Sharp.Tests/TestHelpers/ExpectedFetchState.cs
@@ -39,7 +39,6 @@ internal class ExpectedFetchState
         ///   Constructor.
         /// </summary>
         /// <param name="remoteName">Name of the remote being updated.</param>
-        /// <param name="url">Url of the remote.</param>
         public ExpectedFetchState(string remoteName)
         {
             RemoteName = remoteName;
diff --git a/LibGit2Sharp/Core/Proxy.cs b/LibGit2Sharp/Core/Proxy.cs
@@ -982,7 +982,7 @@ public static IntPtr git_odb_backend_malloc(IntPtr backend, UIntPtr len)
             {
                 throw new LibGit2SharpException(String.Format(CultureInfo.InvariantCulture,
                                                               "Unable to allocate {0} bytes; out of memory",
-                                                              len.ToString()),
+                                                              len),
                                                 GitErrorCode.Error, GitErrorCategory.NoMemory);
             }
 
diff --git a/LibGit2Sharp/DirectReference.cs b/LibGit2Sharp/DirectReference.cs
@@ -18,7 +18,7 @@ protected DirectReference()
         internal DirectReference(string canonicalName, Repository repo, ObjectId targetId)
             : base(canonicalName, targetId.Sha)
         {
-            targetBuilder = new Lazy<GitObject>(() => repo.Lookup(targetId)); ;
+            targetBuilder = new Lazy<GitObject>(() => repo.Lookup(targetId));
         }
 
         /// <summary>
diff --git a/LibGit2Sharp/ObjectDatabase.cs b/LibGit2Sharp/ObjectDatabase.cs
@@ -77,7 +77,7 @@ public virtual Blob CreateBlob(string path)
         public virtual void AddBackend(OdbBackend backend, int priority)
         {
             Ensure.ArgumentNotNull(backend, "backend");
-            Ensure.ArgumentConformsTo<int>(priority, s => s > 0, "priority");
+            Ensure.ArgumentConformsTo(priority, s => s > 0, "priority");
 
             Proxy.git_odb_add_backend(this.handle, backend.GitOdbBackendPointer, priority);
         }
diff --git a/LibGit2Sharp/OdbBackend.cs b/LibGit2Sharp/OdbBackend.cs
@@ -365,7 +365,7 @@ private static unsafe int Write(
                 OdbBackend odbBackend = GCHandle.FromIntPtr(Marshal.ReadIntPtr(backend, GitOdbBackend.GCHandleOffset)).Target as OdbBackend;
 
                 if (odbBackend != null &&
-                    len.ToUInt64() < (ulong)long.MaxValue)
+                    len.ToUInt64() < long.MaxValue)
                 {
                     try
                     {
@@ -403,7 +403,7 @@ private static int WriteStream(
                 OdbBackend odbBackend = GCHandle.FromIntPtr(Marshal.ReadIntPtr(backend, GitOdbBackend.GCHandleOffset)).Target as OdbBackend;
 
                 if (odbBackend != null &&
-                    length.ToUInt64() < (ulong)long.MaxValue)
+                    length.ToUInt64() < long.MaxValue)
                 {
                     OdbBackendStream stream;
 
diff --git a/LibGit2Sharp/OdbBackendStream.cs b/LibGit2Sharp/OdbBackendStream.cs
@@ -146,7 +146,7 @@ private unsafe static int Read(
                 OdbBackendStream odbBackendStream = GCHandle.FromIntPtr(Marshal.ReadIntPtr(stream, GitOdbBackendStream.GCHandleOffset)).Target as OdbBackendStream;
 
                 if (odbBackendStream != null &&
-                    len.ToUInt64() < (ulong)long.MaxValue)
+                    len.ToUInt64() < long.MaxValue)
                 {
                     using (UnmanagedMemoryStream memoryStream = new UnmanagedMemoryStream((byte*)buffer, 0, (long)len.ToUInt64(), FileAccess.ReadWrite))
                     {
@@ -172,7 +172,7 @@ private static unsafe int Write(
                 OdbBackendStream odbBackendStream = GCHandle.FromIntPtr(Marshal.ReadIntPtr(stream, GitOdbBackendStream.GCHandleOffset)).Target as OdbBackendStream;
 
                 if (odbBackendStream != null &&
-                    len.ToUInt64() < (ulong)long.MaxValue)
+                    len.ToUInt64() < long.MaxValue)
                 {
                     long length = (long)len.ToUInt64();
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ internal class ExpectedFetchState`
`39`	`39`	`/// Constructor.`
`40`	`40`	`/// </summary>`
`41`	`41`	`/// <param name="remoteName">Name of the remote being updated.</param>`
`42`		`- /// <param name="url">Url of the remote.</param>`
`43`	`42`	`public ExpectedFetchState(string remoteName)`
`44`	`43`	`{`
`45`	`44`	`RemoteName = remoteName;`
Original file line number	Diff line number	Diff line change
`@@ -982,7 +982,7 @@ public static IntPtr git_odb_backend_malloc(IntPtr backend, UIntPtr len)`
`982`	`982`	`{`
`983`	`983`	`throw new LibGit2SharpException(String.Format(CultureInfo.InvariantCulture,`
`984`	`984`	`"Unable to allocate {0} bytes; out of memory",`
`985`		`- len.ToString()),`
	`985`	`+ len),`
`986`	`986`	`GitErrorCode.Error, GitErrorCategory.NoMemory);`
`987`	`987`	`}`
`988`	`988`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ protected DirectReference()`
`18`	`18`	`internal DirectReference(string canonicalName, Repository repo, ObjectId targetId)`
`19`	`19`	`: base(canonicalName, targetId.Sha)`
`20`	`20`	`{`
`21`		`- targetBuilder = new Lazy<GitObject>(() => repo.Lookup(targetId)); ;`
	`21`	`+ targetBuilder = new Lazy<GitObject>(() => repo.Lookup(targetId));`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ public virtual Blob CreateBlob(string path)`
`77`	`77`	`public virtual void AddBackend(OdbBackend backend, int priority)`
`78`	`78`	`{`
`79`	`79`	`Ensure.ArgumentNotNull(backend, "backend");`
`80`		`- Ensure.ArgumentConformsTo<int>(priority, s => s > 0, "priority");`
	`80`	`+ Ensure.ArgumentConformsTo(priority, s => s > 0, "priority");`
`81`	`81`
`82`	`82`	`Proxy.git_odb_add_backend(this.handle, backend.GitOdbBackendPointer, priority);`
`83`	`83`	`}`
Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@ private static unsafe int Write(`
`365`	`365`	`OdbBackend odbBackend = GCHandle.FromIntPtr(Marshal.ReadIntPtr(backend, GitOdbBackend.GCHandleOffset)).Target as OdbBackend;`
`366`	`366`
`367`	`367`	`if (odbBackend != null &&`
`368`		`- len.ToUInt64() < (ulong)long.MaxValue)`
	`368`	`+ len.ToUInt64() < long.MaxValue)`
`369`	`369`	`{`
`370`	`370`	`try`
`371`	`371`	`{`
`@@ -403,7 +403,7 @@ private static int WriteStream(`
`403`	`403`	`OdbBackend odbBackend = GCHandle.FromIntPtr(Marshal.ReadIntPtr(backend, GitOdbBackend.GCHandleOffset)).Target as OdbBackend;`
`404`	`404`
`405`	`405`	`if (odbBackend != null &&`
`406`		`- length.ToUInt64() < (ulong)long.MaxValue)`
	`406`	`+ length.ToUInt64() < long.MaxValue)`
`407`	`407`	`{`
`408`	`408`	`OdbBackendStream stream;`
`409`	`409`
Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ private unsafe static int Read(`
`146`	`146`	`OdbBackendStream odbBackendStream = GCHandle.FromIntPtr(Marshal.ReadIntPtr(stream, GitOdbBackendStream.GCHandleOffset)).Target as OdbBackendStream;`
`147`	`147`
`148`	`148`	`if (odbBackendStream != null &&`
`149`		`- len.ToUInt64() < (ulong)long.MaxValue)`
	`149`	`+ len.ToUInt64() < long.MaxValue)`
`150`	`150`	`{`
`151`	`151`	`using (UnmanagedMemoryStream memoryStream = new UnmanagedMemoryStream((byte*)buffer, 0, (long)len.ToUInt64(), FileAccess.ReadWrite))`
`152`	`152`	`{`
`@@ -172,7 +172,7 @@ private static unsafe int Write(`
`172`	`172`	`OdbBackendStream odbBackendStream = GCHandle.FromIntPtr(Marshal.ReadIntPtr(stream, GitOdbBackendStream.GCHandleOffset)).Target as OdbBackendStream;`
`173`	`173`
`174`	`174`	`if (odbBackendStream != null &&`
`175`		`- len.ToUInt64() < (ulong)long.MaxValue)`
	`175`	`+ len.ToUInt64() < long.MaxValue)`
`176`	`176`	`{`
`177`	`177`	`long length = (long)len.ToUInt64();`
`178`	`178`