[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumb display in readthedocs theme #3383

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix breadcrumb display in readthedocs theme #3383

merged 2 commits into from
Sep 13, 2023

Conversation

oprypin
Copy link
Contributor
@oprypin oprypin commented Sep 10, 2023
  • Fix broken styling of breadcrumbs in readthedocs theme

    Commit 3c3670d left it half way between the old and new style

    Fixes Something is wrong with readthedocs theme breadcrumbs #3382

  • Fix linkified breadcrumb items in readthedocs theme

    A doc can never have a link attribute so this branch never kicked in.
    Actually even now, this branch will still not kick in, only mkdocs-section-index makes this state possible.

Commit 3c3670d left it half way between the old and new style
A doc can never have a `link` attribute so this branch never kicked in.

Actually even now, this branch will still not kick in, only mkdocs-section-index makes this state possible.
Copy link
Member
@ultrabug ultrabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch o_O

@oprypin oprypin merged commit 0d6fc28 into master Sep 13, 2023
30 checks passed
@oprypin oprypin deleted the breadcrumbs branch September 13, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something is wrong with readthedocs theme breadcrumbs
2 participants