pythongh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (pythonGH-105185)

iritkatriel · miss-islington · commit d86fa18b624b · 2023-06-02T07:59:27.000Z
(cherry picked from commit ee26ca1) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
diff --git a/Doc/c-api/marshal.rst b/Doc/c-api/marshal.rst
@@ -25,12 +25,16 @@ unmarshalling.  Version 2 uses a binary format for floating point numbers.
    the least-significant 32 bits of *value*; regardless of the size of the
    native :c:expr:`long` type.  *version* indicates the file format.
 
+   This function can fail, in which case it sets the error indicator.
+   Use :c:func:`PyErr_Occurred` to check for that.
 
 .. c:function:: void PyMarshal_WriteObjectToFile(PyObject *value, FILE *file, int version)
 
    Marshal a Python object, *value*, to *file*.
    *version* indicates the file format.
 
+   This function can fail, in which case it sets the error indicator.
+   Use :c:func:`PyErr_Occurred` to check for that.
 
 .. c:function:: PyObject* PyMarshal_WriteObjectToString(PyObject *value, int version)
 
diff --git a/Python/marshal.c b/Python/marshal.c
@@ -624,6 +624,10 @@ w_clear_refs(WFILE *wf)
 }
 
 /* version currently has no effect for writing ints. */
+/* Note that while the documentation states that this function
+ * can error, currently it never does. Setting an exception in
+ * this function should be regarded as an API-breaking change.
+ */
 void
 PyMarshal_WriteLongToFile(long x, FILE *fp, int version)
 {

Original file line number	Diff line number	Diff line change
`@@ -624,6 +624,10 @@ w_clear_refs(WFILE *wf)`
`624`	`624`	`}`
`625`	`625`
`626`	`626`	`/* version currently has no effect for writing ints. */`
	`627`	`+/* Note that while the documentation states that this function`
	`628`	`+ * can error, currently it never does. Setting an exception in`
	`629`	`+ * this function should be regarded as an API-breaking change.`
	`630`	`+ */`
`627`	`631`	`void`
`628`	`632`	`PyMarshal_WriteLongToFile(long x, FILE *fp, int version)`
`629`	`633`	`{`