closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (pythonGH-8935)

Alexey Izbyshev · benjaminp · commit b57b4ac042b9 · 2018-08-25T16:52:27.000-07:00
Reported by Svace static analyzer.
diff --git a/Objects/abstract.c b/Objects/abstract.c
@@ -1510,7 +1510,7 @@ PySequence_Check(PyObject *s)
 {
     if (PyDict_Check(s))
         return 0;
-    return s != NULL && s->ob_type->tp_as_sequence &&
+    return s->ob_type->tp_as_sequence &&
         s->ob_type->tp_as_sequence->sq_item != NULL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1510,7 +1510,7 @@ PySequence_Check(PyObject *s)`
`1510`	`1510`	`{`
`1511`	`1511`	`if (PyDict_Check(s))`
`1512`	`1512`	`return 0;`
`1513`		`- return s != NULL && s->ob_type->tp_as_sequence &&`
	`1513`	`+ return s->ob_type->tp_as_sequence &&`
`1514`	`1514`	`s->ob_type->tp_as_sequence->sq_item != NULL;`
`1515`	`1515`	`}`
`1516`	`1516`