bpo-44087: Disallow instantiation of sqlite3.Statement (pythonGH-26567)

Erlend Egeberg Aasland · miss-islington · commit 8756d8672494 · 2021-06-20T19:24:55.000Z
(cherry picked from commit 7d0a47e) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
diff --git a/Lib/sqlite3/test/dbapi.py b/Lib/sqlite3/test/dbapi.py
@@ -25,6 +25,7 @@
 import sqlite3 as sqlite
 import sys
 
+from test.support import check_disallow_instantiation
 from test.support.os_helper import TESTFN, unlink
 
 
@@ -92,6 +93,10 @@ def test_shared_cache_deprecated(self):
                 sqlite.enable_shared_cache(enable)
             self.assertIn("dbapi.py", cm.filename)
 
+    def test_disallow_instantiation(self):
+        cx = sqlite.connect(":memory:")
+        check_disallow_instantiation(self, type(cx("select 1")))
+
 
 class ConnectionTests(unittest.TestCase):
 
diff --git a/Modules/_sqlite/statement.c b/Modules/_sqlite/statement.c
@@ -509,7 +509,7 @@ static PyType_Spec stmt_spec = {
     .name = MODULE_NAME ".Statement",
     .basicsize = sizeof(pysqlite_Statement),
     .flags = (Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC |
-              Py_TPFLAGS_IMMUTABLETYPE),
+              Py_TPFLAGS_IMMUTABLETYPE | Py_TPFLAGS_DISALLOW_INSTANTIATION),
     .slots = stmt_slots,
 };
 PyTypeObject *pysqlite_StatementType = NULL;
