pythongh-135646: Raise consistent NameError exceptions in ForwardRef.evaluate() (pythonGH-135663)

Viicos · miss-islington · commit 846c2400d32e · 2025-06-18T13:01:01.000Z
(cherry picked from commit 343719d) Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
diff --git a/Lib/annotationlib.py b/Lib/annotationlib.py
@@ -27,6 +27,9 @@ class Format(enum.IntEnum):
 
 
 _sentinel = object()
+# Following `NAME_ERROR_MSG` in `ceval_macros.h`:
+_NAME_ERROR_MSG = "name '{name:.200}' is not defined"
+
 
 # Slots shared by ForwardRef and _Stringifier. The __forward__ names must be
 # preserved for compatibility with the old typing.ForwardRef class. The remaining
@@ -184,7 +187,7 @@ def evaluate(
             elif is_forwardref_format:
                 return self
             else:
-                raise NameError(arg)
+                raise NameError(_NAME_ERROR_MSG.format(name=arg), name=arg)
         else:
             code = self.__forward_code__
             try:
diff --git a/Lib/test/test_annotationlib.py b/Lib/test/test_annotationlib.py
@@ -1650,9 +1650,11 @@ def test_name_lookup_without_eval(self):
         with support.swap_attr(builtins, "int", dict):
             self.assertIs(ForwardRef("int").evaluate(), dict)
 
-        with self.assertRaises(NameError):
+        with self.assertRaises(NameError, msg="name 'doesntexist' is not defined") as exc:
             ForwardRef("doesntexist").evaluate()
 
+        self.assertEqual(exc.exception.name, "doesntexist")
+
     def test_fwdref_invalid_syntax(self):
         fr = ForwardRef("if")
         with self.assertRaises(SyntaxError):
diff --git a/Misc/NEWS.d/next/Library/2025-06-18-11-43-17.gh-issue-135646.r7ekEn.rst b/Misc/NEWS.d/next/Library/2025-06-18-11-43-17.gh-issue-135646.r7ekEn.rst
@@ -0,0 +1 @@
+Raise consistent :exc:`NameError` exceptions in :func:`annotationlib.ForwardRef.evaluate`

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Raise consistent :exc:`NameError` exceptions in :func:`annotationlib.ForwardRef.evaluate`