Don't pass unicode to pyflakes (python-lsp#372)

muffinmad · gatesn · commit f3b71b3fea26 · 2018-06-29T13:58:52.000+02:00
* Don't pass unicode to pyflakes

* unicode for py34 tests
diff --git a/pyls/plugins/pyflakes_lint.py b/pyls/plugins/pyflakes_lint.py
@@ -21,7 +21,7 @@
 @hookimpl
 def pyls_lint(document):
     reporter = PyflakesDiagnosticReport(document.lines)
-    pyflakes_api.check(document.source, document.path, reporter=reporter)
+    pyflakes_api.check(document.source.encode('utf-8'), document.path, reporter=reporter)
     return reporter.diagnostics
 
 
diff --git a/test/plugins/test_pyflakes_lint.py b/test/plugins/test_pyflakes_lint.py
@@ -19,6 +19,11 @@ def hello():
 DOC_UNDEFINED_NAME_ERR = "a = b"
 
 
+DOC_ENCODING = u"""# encoding=utf-8
+import sys
+"""
+
+
 def test_pyflakes():
     doc = Document(DOC_URI, DOC)
     diags = pyflakes_lint.pyls_lint(doc)
@@ -47,3 +52,11 @@ def test_undefined_name_pyflakes():
     assert diag['message'] == 'undefined name \'b\''
     assert diag['range']['start'] == {'line': 0, 'character': 4}
     assert diag['severity'] == lsp.DiagnosticSeverity.Error
+
+
+def test_unicode_encoding():
+    doc = Document(DOC_URI, DOC_ENCODING)
+    diags = pyflakes_lint.pyls_lint(doc)
+
+    assert len(diags) == 1
+    assert diags[0]['message'] == '\'sys\' imported but unused'
