pycodestyle config: convert arrays to comma seperated strings (python-lsp#164)

lgeiger · gatesn · commit ca237ce30c94 · 2017-10-23T13:56:02.000+01:00
diff --git a/pyls/_utils.py b/pyls/_utils.py
@@ -23,3 +23,7 @@ def debounced(*args, **kwargs):
 def camel_to_underscore(string):
     s1 = FIRST_CAP_RE.sub(r'\1_\2', string)
     return ALL_CAP_RE.sub(r'\1_\2', s1).lower()
+
+
+def list_to_string(value):
+    return ",".join(value) if type(value) == list else value
diff --git a/pyls/plugins/pycodestyle_lint.py b/pyls/plugins/pycodestyle_lint.py
@@ -26,7 +26,7 @@ def _config_from_files(config_files):
 
     # Then, read the PYLS configuration
     ide_conf = config.plugin_settings('pycodestyle')
-    conf.update({_utils.camel_to_underscore(k): v for k, v in ide_conf.items()})
+    conf.update({_utils.camel_to_underscore(k): _utils.list_to_string(v) for k, v in ide_conf.items()})
 
     # Finally, read the project configuration
     conf.update(_config_from_files(config.find_parents(document.path, CONFIG_FILES)))
diff --git a/test/test_utils.py b/test/test_utils.py
@@ -24,3 +24,13 @@ def call_m():
     time.sleep(interval * 2)
     call_m()
     assert call_m._count == 2
+
+
+def test_list_to_string():
+    assert _utils.list_to_string("string") == "string"
+    assert _utils.list_to_string(["a", "r", "r", "a", "y"]) == "a,r,r,a,y"
+
+
+def test_camel_to_underscore():
+    assert _utils.camel_to_underscore("camelCase") == "camel_case"
+    assert _utils.camel_to_underscore("under_score") == "under_score"
