fix user.rename, user.impersonate, user.revoke_impersonatio, user.delete

goodwillcoding · goodwillcoding · commit 40762ae9d9cf · 2016-10-26T21:21:33.000-07:00
to use username, not id as required by the API
diff --git a/github3/users.py b/github3/users.py
@@ -391,7 +391,7 @@ def rename(self, login):
         :param str login: (required), new name of the user
         :returns: bool
         """
-        url = self._build_url('admin', 'users', self.id)
+        url = self._build_url('admin', 'users', self.login)
         payload = {'login': login}
         resp = self._boolean(self._patch(url, data=payload), 202, 403)
         return resp
@@ -407,7 +407,7 @@ def impersonate(self, scopes=None):
             i.e., 'gist', 'user'
         :returns: :class:`Authorization <Authorization>`
         """
-        url = self._build_url('admin', 'users', self.id, 'authorizations')
+        url = self._build_url('admin', 'users', self.login, 'authorizations')
         data = {}
 
         if scopes:
@@ -425,7 +425,7 @@ def revoke_impersonation(self):
 
         :returns: bool -- True if successful, False otherwise
         """
-        url = self._build_url('admin', 'users', self.id, 'authorizations')
+        url = self._build_url('admin', 'users', self.login, 'authorizations')
 
         return self._boolean(self._delete(url), 204, 403)
 
@@ -494,5 +494,5 @@ def delete(self):
 
         :returns: bool -- True if successful, False otherwise
         """
-        url = self._build_url('admin', 'users', self.id)
+        url = self._build_url('admin', 'users', self.login)
         return self._boolean(self._delete(url), 204, 403)
