[Tests] Fix broken tests due to faker deprecations and PHP 8.2

lindyhopchris · lindyhopchris · commit 8694346f8453 · 2023-01-21T17:34:27.000Z
diff --git a/tests/dummy/database/factories/ModelFactory.php b/tests/dummy/database/factories/ModelFactory.php
@@ -70,7 +70,7 @@
 /** Image */
 $factory->define(DummyApp\Image::class, function (Faker $faker) {
     return [
-        'url' => $faker->imageUrl(),
+        'url' => $faker->url(),
     ];
 });
 
diff --git a/tests/lib/Integration/ErrorsTest.php b/tests/lib/Integration/ErrorsTest.php
@@ -200,7 +200,7 @@ public function testCustomInvalidJson()
      * whatever error is generated by the application must be returned as a JSON API error
      * even if the error has not been generated from one of the configured APIs.
      */
-    public function testClientWantsJsonApiError()
+    public function testClientWantsJsonApiError(): void
     {
         $expected = [
             'errors' => [
@@ -218,7 +218,7 @@ public function testClientWantsJsonApiError()
         $response
             ->assertStatus(404)
             ->assertHeader('Content-Type', 'application/vnd.api+json')
-            ->assertExactJson($expected);
+            ->assertJson($expected);
     }
 
     /**
diff --git a/tests/lib/Integration/PackageTest.php b/tests/lib/Integration/PackageTest.php
@@ -51,10 +51,8 @@ public function testReadBlog()
     /**
      * Test that we can read a resource from the application.
      */
-    public function testReadPost()
+    public function testReadPost(): void
     {
-        $this->resourceType = 'posts';
-
         /** @var Post $post */
         $post = factory(Post::class)->create();
 
diff --git a/tests/lib/Integration/Validation/QueryValidationTest.php b/tests/lib/Integration/Validation/QueryValidationTest.php
@@ -117,8 +117,6 @@ public function testSearch(array $params, string $param, string $detail)
             'source' => ['parameter' => $param],
         ];
 
-        $this->resourceType = 'posts';
-
         $response = $this
             ->jsonApi('posts')
             ->query($params)
