Replace constants (static final CONSTANT_CASE) declaration type which use the general collection interface (e.g. List) with an immutable type (e.g. ImmutableList).

dorireuv · garrettjonesgoogle · commit 98e6d4865c85 · 2017-06-30T15:00:24.000-07:00
For constant field declarations, you should use the immutable type (such as ImmutableList) instead of the general collection interface type (such as List). This communicates to your callers important semantic guarantees (https://cantata.corp.google.com/?ticket=java:com.google.common.collect.ImmutableCollection). For more info, see: go/lsc-immutable-constants Cleanup change automatically generated by javacflume/refactory Refactoring: //third_party/java_src/error_prone/project/core/src/main/java/com/google/errorprone/bugpatterns:MutableConstantField_refactoring Tested: TAP train for global presubmit queue http://test/OCL:149234672:BASE:149234770:1488739899777:b922b37f All failing tests were failing before this change ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=150033774
diff --git a/google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java b/google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java
@@ -35,7 +35,6 @@
 import java.io.IOException;
 import java.util.Arrays;
 import java.util.List;
-import java.util.Set;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Executor;
 import java.util.concurrent.Future;
@@ -52,9 +51,9 @@
  */
 public class HttpRequestTest extends TestCase {
 
-  private static final Set<String> BASIC_METHODS =
+  private static final ImmutableSet<String> BASIC_METHODS =
       ImmutableSet.of(HttpMethods.GET, HttpMethods.PUT, HttpMethods.POST, HttpMethods.DELETE);
-  private static final Set<String> OTHER_METHODS =
+  private static final ImmutableSet<String> OTHER_METHODS =
       ImmutableSet.of(HttpMethods.HEAD, HttpMethods.PATCH);
 
   public HttpRequestTest(String name) {
