8000 Group test explorer test by workspace in multi-root workspace · Issue #20345 · microsoft/vscode-python · GitHub
[go: up one dir, main page]
Skip to content

Group test explorer test by workspace in multi-root workspace #20345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
claudius-kienle opened this issue Dec 7, 2022 · 6 comments
Closed

Group test explorer test by workspace in multi-root workspace #20345

claudius-kienle opened this issue Dec 7, 2022 · 6 comments
Assignees
@eleanorjboyd
Labels
area-testing feature-request Request for new features or functionality

Comments

@claudius-kienle
Copy link

I am using the multi-root workspace in vs code to open multiple python packages, each with their own tests folder containing the tests for that package.
The test explorer displays all tests, but does not group them by the workspace they come from.
For a simple multi-root workspace with just two packages, this looks like the following screenshot:
image

Since all folders are named in the same way, its cumbersome to determine which entry is from which workspace.

I also searched through the extension's settings, but didn't find anyting related.

I think the best solution would be to group the tests simililarly as in the repositories in the source control view. What do you think?
@claudius-kienle claudius-kienle added the feature-request Request for new features or functionality label Dec 7, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Dec 7, 2022
@eleanorjboyd eleanorjboyd self-assigned this Dec 8, 2022
@eleanorjboyd
Copy link
Member

@claudius-kienle, thank you for submitting this issue! I just had a quick clarifying question before I dive into the desired behavior here. In order to get your test explorer to look like this, do you first discover tests in the first workspace and then the second workspace? Ie does it take two steps for you to see this list in your test explorer?

@eleanorjboyd eleanorjboyd added area-testing info-needed Issue requires more information from poster labels Dec 13, 2022
@claudius-kienle
Copy link
Author
claudius-kienle commented Dec 13, 2022 •
edited
Loading

Yes exactly, I execute Python: Configure Tests for each of the workspaces, which creates configs like the following in each workspace's settings.json:

{
   "python.testing.unittestArgs": [
        "-v",
        "-s",
        "./tests",
        "-p",
        "test*.py"
    ],
    "python.testing.pytestEnabled": false,
    "python.testing.unittestEnabled": true
}

@eleanorjboyd
Copy link
Member

@claudius-kienle, great thank you for the quick reply!

@eleanorjboyd
Copy link
Member

@brettcannon and @luabud what is the desired workflow do you think in this case? Since it requires a step to discover tests in each workspace should a multi-root workspace have the workspace listed on discovering tests for a single workspace or just for discovering more than one workspace? Additionally should the workspace be displayed the same way as a folder is (so above tests in this given example with tests nested under)? The final implementation question to consider is the 3 buttons, run, run in debug mode, and go to file and what these buttons should do given it is in reference to a workspace instead of a file. I think it can behave pretty much the same given workspaces still have paths with which we could direct to or run tests in. Thanks and let me know if you have opinions on the matter.

@brettcannon
Copy link
Member

Ideally a multi-root workspace would have one more level of hierarchy per workspace at the top of the tree. Otherwise I would consider it all the same as if it was a single-root workspace.

@eleanorjboyd eleanorjboyd removed info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team labels Dec 16, 2022
@eleanorjboyd eleanorjboyd mentioned this issue Dec 19, 2022
Closed
22 tasks
@eleanorjboyd
Copy link
Member

Hello! We have just finished our testing rewrite and are beginning the roll out to users. I have tested this issue with the re-write and think it has your desired behavior with the workspaces seperated! If you would like to try it yourself, you need to be on vscode insiders and then add this setting to your users settings.json "python.experiments.optInto": ["pythonTestAdapter"]. We are in the processes of switching all users to the rewrite but are doing so incrementally so if you do not have insiders, watch our release notes to get updated on when it will begin to hit stable. Let me know if it doesn’t work for you and we can re-open this issue. Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eleanorjboyd eleanorjboyd

Labels
area-testing feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @claudius-kienle @eleanorjboyd
0