8000 Remove sourceMaps (#24561) · microsoft/vscode-python@b342559 · GitHub
[go: up one dir, main page]
Skip to content

Commit b342559

Browse files
karthiknadigkarthiknadig
authored
Remove sourceMaps (#24561)
Fixes #13961
1 parent 9f4e4f2 commit b342559

17 files changed

+4
-513
lines changed

‎.eslintignore

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ src/test/proc.ts
1717
src/test/smokeTest.ts
1818
src/test/standardTest.ts
1919
src/test/startupTelemetry.unit.test.ts
20-
src/test/sourceMapSupport.test.ts
21-
src/test/sourceMapSupport.unit.test.ts
2220
src/test/testBootstrap.ts
2321
src/test/testLogger.ts
2422
src/test/testRunner.ts
@@ -129,7 +127,6 @@ src/test/application/diagnostics/checks/invalidPythonPathInDebugger.unit.test.ts
129127
src/test/application/diagnostics/checks/envPathVariable.unit.test.ts
130128
src/test/application/diagnostics/applicationDiagnostics.unit.test.ts
131129
src/test/application/diagnostics/promptHandler.unit.test.ts
132-
src/test/application/diagnostics/sourceMapSupportService.unit.test.ts
133130
src/test/application/diagnostics/commands/ignore.unit.test.ts
134131

135132
src/test/performance/load.perf.test.ts
@@ -145,7 +142,6 @@ src/client/interpreter/virtualEnvs/condaInheritEnvPrompt.ts
145142
src/client/interpreter/display/index.ts
146143

147144
src/client/extension.ts
148-
src/client/sourceMapSupport.ts
149145
src/client/startupTelemetry.ts
150146

151147
src/client/terminals/codeExecution/terminalCodeExecution.ts

‎gulpfile.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,6 @@ function getAllowedWarningsForWebPack(buildConfig) {
222222
throw new Error('Unknown WebPack Configuration');
223223
}
224224
}
225-
gulp.task('renameSourceMaps', async () => {
226-
// By default source maps will be disabled in the extension.
227-
// Users will need to use the command `python.enableSourceMapSupport` to enable source maps.
228-
const extensionSourceMap = path.join(__dirname, 'out', 'client', 'extension.js.map');
229-
await fsExtra.rename(extensionSourceMap, `${extensionSourceMap}.disabled`);
230-
});
231225

232226
gulp.task('verifyBundle', async () => {
233227
const matches = await glob.sync(path.join(__dirname, '*.vsix'));
@@ -238,7 +232,7 @@ gulp.task('verifyBundle', async () => {
238232
}
239233
});
240234

241-
gulp.task('prePublishBundle', gulp.series('webpack', 'renameSourceMaps'));
235+
gulp.task('prePublishBundle', gulp.series('webpack'));
242236
gulp.task('checkDependencies', gulp.series('checkNativeDependencies'));
243237
gulp.task('prePublishNonBundle', gulp.series('compile'));
244238

‎package.json

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -300,11 +300,6 @@
300300
"command": "python.createEnvironment-button",
301301
"title": "%python.command.python.createEnvironment.title%"
302302
},
303-
{
304-
"category": "Python",
305-
"command": "python.enableSourceMapSupport",
306-
"title": "%python.command.python.enableSourceMapSupport.title%"
307-
},
308303
{
309304
"category": "Python",
310305
"command": "python.execInTerminal",
@@ -443,12 +438,6 @@
443438
"scope": "machine-overridable",
444439
"type": "string"
445440
},
446-
"python.diagnostics.sourceMapsEnabled": {
447-
"default": false,
448-
"description": "%python.diagnostics.sourceMapsEnabled.description%",
449-
"scope": "application",
450-
"type": "boolean"
451-
},
452441
"python.envFile": {
453442
"default": "${workspaceFolder}/.env",
454443
"description": "%python.envFile.description%",
@@ -1297,12 +1286,6 @@
12971286
"title": "%python.command.python.createTerminal.title%",
12981287
"when": "!virtualWorkspace && shellExecutionSupported"
12991288
},
1300-
{
1301-
"category": "Python",
1302-
"command": "python.enableSourceMapSupport",
1303-
"title": "%python.command.python.enableSourceMapSupport.title%",
1304-
"when": "!virtualWorkspace && shellExecutionSupported"
1305-
},
13061289
{
13071290
"category": "Python",
13081291
"command": "python.execInTerminal",

‎package.nls.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"python.command.python.execInREPL.title": "Run Selection/Line in Python REPL",
1919
"python.command.python.execSelectionInDjangoShell.title": "Run Selection/Line in Django Shell",
2020
"python.command.python.reportIssue.title": "Report Issue...",
21-
"python.command.python.enableSourceMapSupport.title": "Enable Source Map Support For Extension Debugging",
2221
"python.command.python.clearCacheAndReload.title": "Clear Cache and Reload Window",
2322
"python.command.python.analysis.restartLanguageServer.title": "Restart Language Server",
2423
"python.command.python.launchTensorBoard.title": "Launch TensorBoard",
@@ -33,7 +32,6 @@
3332
"python.condaPath.description": "Path to the conda executable to use for activation (version 4.4+).",
3433
"python.debugger.deprecatedMessage": "This configuration will be deprecated soon. Please replace `python` with `debugpy` to use the new Python Debugger extension.",
3534
"python.defaultInterpreterPath.description": "Path to default Python to use when extension loads up for the first time, no longer used once an interpreter is selected for the workspace. See [here](https://aka.ms/AAfekmf) to understand when this is used",
36-
"python.diagnostics.sourceMapsEnabled.description": "Enable source map support for meaningful stack traces in error logs.",
3735
"python.envFile.description": "Absolute path to a file containing environment variable definitions.",
3836
"python.experiments.enabled.description": "Enables A/B tests experiments in the Python extension. If enabled, you may get included in proposed enhancements and/or features.",
3937
"python.experiments.optInto.description": "List of experiments to opt into. If empty, user is assigned the default experiment groups. See [here](https://github.com/microsoft/vscode-python/wiki/AB-Experiments) for more details.",

‎src/client/application/diagnostics/applicationDiagnostics.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { Resource } from '../../common/types';
99
import { IServiceContainer } from '../../ioc/types';
1010
import { traceLog, traceVerbose } from '../../logging';
1111
import { IApplicationDiagnostics } from '../types';
12-
import { IDiagnostic, IDiagnosticsService, ISourceMapSupportService } from './types';
12+
import { IDiagnostic, IDiagnosticsService } from './types';
1313

1414
function log(diagnostics: IDiagnostic[]): void {
1515
diagnostics.forEach((item) => {
@@ -43,9 +43,7 @@ async function runDiagnostics(diagnosticServices: IDiagnosticsService[], resourc
4343
export class ApplicationDiagnostics implements IApplicationDiagnostics {
4444
constructor(@inject(IServiceContainer) private readonly serviceContainer: IServiceContainer) {}
4545

46-
public register() {
47-
this.serviceContainer.get<ISourceMapSupportService>(ISourceMapSupportService).register();
48-
}
46+
public register() {}
4947

5048
public async performPreStartupHealthCheck(resource: Resource): Promise<void> {
5149
// When testing, do not perform health checks, as modal dialogs can be displayed.

‎src/client/application/diagnostics/surceMapSupportService.ts

Lines changed: 0 additions & 46 deletions
This file was deleted.

‎src/client/application/diagnostics/types.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,3 @@ export const IInvalidPythonPathInDebuggerService = Symbol('IInvalidPythonPathInD
6464
export interface IInvalidPythonPathInDebuggerService extends IDiagnosticsService {
6565
validatePythonPath(pythonPath?: string, pythonPathSource?: PythonPathSource, resource?: Uri): Promise<boolean>;
6666
}
67-
export const ISourceMapSupportService = Symbol('ISourceMapSupportService');
68-
export interface ISourceMapSupportService {
69-
register(): void;
70-
enable(): Promise<void>;
71-
}

‎src/client/application/serviceRegistry.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@
55

66
import { IServiceManager } from '../ioc/types';
77
import { registerTypes as diagnosticsRegisterTypes } from './diagnostics/serviceRegistry';
8-
import { SourceMapSupportService } from './diagnostics/surceMapSupportService';
9-
import { ISourceMapSupportService } from './diagnostics/types';
108

119
export function registerTypes(serviceManager: IServiceManager) {
12-
serviceManager.addSingleton<ISourceMapSupportService>(ISourceMapSupportService, SourceMapSupportService);
1310
diagnosticsRegisterTypes(serviceManager);
1411
}

‎src/client/common/application/commands.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ interface ICommandNameWithoutArgumentTypeMapping {
3434
['editor.action.rename']: [];
3535
[Commands.ViewOutput]: [];
3636
[Commands.Start_REPL]: [];
37-
[Commands.Enable_SourceMap_Support]: [];
3837
[Commands.Exec_Selection_In_Terminal]: [];
3938
[Commands.Exec_Selection_In_Django_Shell]: [];
4039
[Commands.Create_Terminal]: [];

‎src/client/common/constants.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ export namespace Commands {
4242
export const Create_Environment_Check = 'python.createEnvironmentCheck';
4343
export const Create_Terminal = 'python.createTerminal';
4444
export const Debug_In_Terminal = 'python.debugInTerminal';
45-
export const Enable_SourceMap_Support = 'python.enableSourceMapSupport';
4645
export const Exec_In_Terminal = 'python.execInTerminal';
4746
export const Exec_In_Terminal_Icon = 'python.execInTerminal-icon';
4847
export const Exec_In_Separate_Terminal = 'python.execInDedicatedTerminal';

0 commit comments

Comments
 (0)
0