Closed
Description
Please fix them both in the example project here and in the online tutorial. :)
PEP8
- spaces around the
=of keywords args - PEP8 forbids spaces there - inconsistent indentation (some function bodies are indented with 8 spaces)
- local imports for no reason (
datetimeinhello_there) - not directly a PEP8 violation but local stdlib imports don't really make sense
Flask stuff
- please consider removing the example with the hardcoded HTML. some people WILL think it's OK to do that even if you mention that usually templates are used. also, that hardcoded-html example is vulnerable to XSS.
href="/static/site.css"- usehref="{{ url_for('static', filename='site.css')}}"message="Hello there, " + name + "!",- usually you would pass just thenameto the template and then build the message in there. So I would change this, and also do thestrftimecall in the template (ideally someone would use e.g. flask-babel but that's out of the scope of a simple tutorial)
Note: I'm one of the flask maintainers, and I can assure you that people WILL assume things are good / ok / the way to go when part of a tutorial. I've seen my share of bad practices from code people posted in our IRC channel.
Metadata
Metadata
Assignees
Labels
No labels