8000 [Bug]: deprecated `is_visible` arguments that were removed in 1.53 are still present in `_generated.py` · Issue #2904 · microsoft/playwright-python · GitHub
[go: up one dir, main page]

Skip to content
[Bug]: deprecated is_visible arguments that were removed in 1.53 are still present in _generated.py #2904
Closed
@DetachHead

Description

@DetachHead

Version

1.53.0

Steps to reproduce

from playwright.sync_api import sync_playwright

with sync_playwright() as p:
    browser = p.chromium.launch()
    page = browser.new_page()
    page.is_visible("asdf", timeout=1)

Expected behavior

an error from my type checker

Actual behavior

runtime error:

TypeError: Frame.is_visible() got an unexpected keyword argument 'timeout'

Additional context

removing these arguments have previously been discussed in microsoft/playwright#33017, though it looks like this runtime crash is exclusive to playwright-python

i'm glad these deprecated arguments have finally been removed though. even having it crash at runtime is a massive improvement compared to just silently ignoring the argument.

Environment

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0