8000 port: Fix first activity from bot to user has fake replyToId value by gandiddi · Pull Request #2145 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]

Skip to content

port: Fix first activity from b 8000 ot to user has fake replyToId value #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

gandiddi
Copy link
Contributor

Fixes #1695

Description

Porting Fix first activity from bot to user has fake replyToId value (#5313) to maintain parity with microsoft/botbuilder-dotnet

When the activity is the first one of the conversation and it's sent from bot to user, the ReplyToId was assigned to the bogus ConversationUpdate activity's id. The fix is to not assign the bogus ReplyToId if previous activity is the ConversationUpdate activity

Specific Changes

  • Do not assign ReplyToId if conversantionReference is from ConversationUpdate activity

Note: The test cases included in the porting PR are not added here, as they have been reverted to maintain 100% code coverage for Microsoft.Bot.Schema.

@gandiddi gandiddi requested a review from a team as a code owner July 30, 2024 14:34
@gandiddi gandiddi requested a review from tracyboehrer July 31, 2024 11:10
@tracyboehrer tracyboehrer merged commit 1099ffd into main Aug 5, 2024
7 checks passed
@tracyboehrer tracyboehrer deleted the v-gandidd/FixReplyToId branch August 5, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Fix first activity from bot to user has fake replyToId value (#5313)
2 participants
0