8000 Fix Telemetry Logger attachments by iKnowRam · Pull Request #1888 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content

Fix Telemetry Logger attachments #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 28, 2022
Merged

Fix Telemetry Logger attachments #1888

merged 7 commits into from
Jan 28, 2022

Conversation

iKnowRam
Copy link
Contributor

Fixes #1880 An activity with attachments raises an exception in telemetry logger

Description

  1. Removed .strip() method that was being called on a list as it was throwing AttributeError: 'list' object has no attribute 'strip' error.
  2. Serialized the Attachment object to Json.

@iKnowRam iKnowRam requested review from axelsrz and daveta January 13, 2022 21:14
@iKnowRam iKnowRam requested a review from a team as a code owner January 13, 2022 21:14
@carlosscastro
Copy link
Member

@axelsrz could you help drive this PR? Thanks :)

@axelsrz axelsrz merged commit 16f55f8 into main Jan 28, 2022
@axelsrz axelsrz deleted the ramfattah/telemetry-logger-middleware-fix branch January 28, 2022 21:54
@anishprasad01 anishprasad01 mentioned this pull request May 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelsrz axelsrz axelsrz approved these changes

@tracyboehrer tracyboehrer Awaiting requested review from tracyboehrer

@tdurnford tdurnford Awaiting requested review from tdurnford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An activity with attachments raises an exception in telemetry logger
3 participants
@iKnowRam @carlosscastro @axelsrz
0