8000 [Bug] Can not emulate Python bot with Bot Framework Emulator. Shall we remove APP_ID check when init ConfigurationServiceClientCredentialFactory? · Issue #2133 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content

[Bug] Can not emulate Python bot with Bot Framework Emulator. Shall we remove APP_ID check when init ConfigurationServiceClientCredentialFactory? #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
frankqianms opened this issue Jul 3, 2024 · 0 comments · Fixed by #2135
Closed

[Bug] Can not emulate Python bot with Bot Framework Emulator. Shall we remove APP_ID check when init ConfigurationServiceClientCredentialFactory? #2133

frankqianms opened this issue Jul 3, 2024 · 0 comments · Fixed by #2135
Labels
bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@frankqianms
Copy link

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

What package version of the SDK are you using.

Describe the bug

I found that recently APP_ID empty check has been added in the SDK: 579888d#:~:text=not%20supported%22)-,if%20app_type%20%3D%3D%20%22userassignedmsi%22%3A,Exception(%22Property%20%27APP_ID%27%20is%20expected%20in%20configuration%20object%22),-app_tenantid%20%3D%20(.
However, tools like Bot Framework Emulator allow users to bypass APP_ID and APP_PASSWORD to emulate bot activities. Do we really need this check? Is it by design? If not, shall we remove it?

To Reproduce

Steps to reproduce the behavior:

  1. Create a Python Teams bot
  2. Use Bot Framework Emulator
  3. See error

Expected behavior

Users can bypass APP_ID and APP_PASSWORD in the Python bot
@frankqianms frankqianms added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jul 3, 2024
@tracyboehrer tracyboehrer mentioned this issue Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
1 participant
@frankqianms
0