get_access_token: error checking

andreikop · andreikop · commit 5e073e0c68fc · 2021-11-30T12:36:55.000+03:00
In case if msal_app().acquire_token_silent() returns an error
raise an exception with error details instead of crashing with KeyError
diff --git a/libraries/botframework-connector/botframework/connector/auth/microsoft_app_credentials.py b/libraries/botframework-connector/botframework/connector/auth/microsoft_app_credentials.py
@@ -62,6 +62,14 @@ def get_access_token(self, force_refresh: bool = False) -> str:
             auth_token = self.__get_msal_app().acquire_token_for_client(
                 scopes=self.scopes
             )
+
+        # acquire_token...() returns None if there are no any tokens and
+        # a dict which contains 'error' in case of error
+        if auth_token is None:
+            raise UserWarning("No any access tokens")
+        if 'error' in auth_token:
+            raise UserWarning(f"Failed to get access token: {auth_token}")
+
         return auth_token["access_token"]
 
     def __get_msal_app(self):
