Throw if is_skill_claim and claims_validator is null (#1375)

EricDahlvang · web-flow · commit 159901f4e447 · 2020-09-03T16:41:44.000-07:00
* Throw if is_skill_claim and claims_validator is null

* Update jwt_token_validation.py
diff --git a/libraries/botframework-connector/botframework/connector/auth/jwt_token_validation.py b/libraries/botframework-connector/botframework/connector/auth/jwt_token_validation.py
@@ -165,6 +165,9 @@ async def validate_claims(
     ):
         if auth_config and auth_config.claims_validator:
             await auth_config.claims_validator(claims)
+        elif SkillValidation.is_skill_claim(claims):
+            # Skill claims must be validated using AuthenticationConfiguration claims_validator
+            raise PermissionError("Unauthorized Access. Request is not authorized. Skill Claims require validation.")
 
     @staticmethod
     def is_government(channel_service: str) -> bool:
