8000 tests: Fix macos CI by dpgeorge · Pull Request #7918 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

tests: Fix macos CI #7918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

tests: Fix macos CI #7918

merged 1 commit into from
Oct 21, 2021

Conversation

dpgeorge
Copy link
Member

No description provided.

@dpgeorge dpgeorge added the tests Relates to tests/ directory in source label Oct 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #7918 (2a09106) into master (30268c9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7918      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files         154      154              
  Lines       20007    20007              
==========================================
- Hits        19656    19655       -1     
- Misses        351      352       +1
Impacted Files Coverage Δ
py/parse.c 99.00% <0.00%> (-0.20%) ⬇️
py/runtime.c 99.24% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30268c9...2a09106. Read the comment docs.

@dpgeorge
Copy link
Member Author

The macos CI uses Python 3.10.0, which has had the following changes which affect the following tests:

@dpgeorge dpgeorge force-pushed the tests-fix-macos-ci-python-3-10 branch from af6cb07 to b954413 Compare October 21, 2021 04:49
@dpgeorge
github/workflows: Use Python 3.8 for macos workflow.
f4c1389 
Otherwise it gets a more recent version which fails some of the test suite.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the tests-fix-macos-ci-python-3-10 branch from b954413 to f4c1389 Compare October 21, 2021 05:04
@dpgeorge dpgeorge merged commit f4c1389 into micropython:master Oct 21, 2021
@dpgeorge dpgeorge deleted the tests-fix-macos-ci-python-3-10 branch October 21, 2021 05:33
@dpgeorge dpgeorge mentioned this pull request Oct 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Relates to tests/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpgeorge @codecov-commenter
0