rp2: Allow boards to configure I2C/SPI pins using new macros.#7513
Closed
mcauser wants to merge 2 commits intomicropython:masterfrom
Closed
rp2: Allow boards to configure I2C/SPI pins using new macros.#7513mcauser wants to merge 2 commits intomicropython:masterfrom
mcauser wants to merge 2 commits intomicropython:masterfrom
Conversation
dpgeorge
approved these changes
Jul 17, 2021
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next steps, update each
mpconfigboard.hin/ports/rp2/boards/*with the board's preferred pins. eg.As mentioned in #7476
UART1is currently defaulting to4,5which conflicts with the latest PICO pinout diagrams preferred pins.Theres a PR which allows changing the default UART pins: #7503
Once that's merged, boards can put
UART1on8,9and give4,5toI2C0and19,16,18,17toSPI0.By having all UART, I2C and SPI default pins configurable, boards now have the freedom to pick and choose their favourites.