/esp32/boards: Add LOLIN_S3_PRO board definition. #17290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a board definition for the Wemos Lolin S3 Pro.
Testing
I deployed the firmware to my S3 Pro, it appeared to work fine. Tested the filesystem (since a key feature of this board is the 16MB flash) and the GRB (not RGB) LED:
Trade-offs and Alternatives
A user could define their own custom board. We could also extend ESP32_GENERIC_S3 to support 16MB models (which may be wroth doing as well).
See #17217 for a request for this board.