8000 esp32/boards/LOLIN_C3_MINI/mpconfigboard.h: Enabled i2s. by StrayCatNZ · Pull Request #16516 · micropython/micropython · GitHub
[go: up one dir, main page]

Skip to content

esp32/boards/LOLIN_C3_MINI/mpconfigboard.h: Enabled i2s. #16516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

StrayCatNZ
Copy link
Contributor

Summary

Enabled i2s for lolin_c3_mini as it works fine now.

Testing

Tested on esp32_c3_SuperMini and it works great!

Signed-off-by: StrayCat <marcin.eu@gmail.com>
@StrayCatNZ StrayCatNZ marked this pull request as ready for review January 2, 2025 10:53
@StrayCatNZ StrayCatNZ mentioned this pull request Jan 3, 2025
@jonnor
Copy link
Contributor
jonnor commented Jan 3, 2025

This should maybe be on all ESP32C3 devices? I do not see any reason why this feature would be board specific?

@StrayCatNZ
Copy link
Contributor Author

This should maybe be on all ESP32C3 devices? I do not see any reason why this feature would be board specific?

Most likely yes, I can also change it in generic c3. I only have esp32c3 supermini to test it on though, if you think that will be enough of a test?

@jonnor
Copy link
Contributor
jonnor commented Jan 5, 2025

If you only have one, that is ok. Hopefully one other person is able to test on another C3! That would be ideal :)

Signed-off-by: StrayCat <marcin.eu@gmail.com>
@StrayCatNZ
Copy link
Contributor Author

If you only have one, that is ok. Hopefully one other person is able to test on another C3! That would be ideal :)

I also flashed ESP32_GENERIC_C3 version into my esp32c3 mini and i2s works with this firmware too.

So far I'm using my esp32c3 mini with this patch in a project where it plays audio with i2s, controls some leds and communicates with lego hub at the same time and no issues so far, so super happy about that! :)
https://github.com/user-attachments/assets/8462c1c0-13eb-4cad-86ff-dab7c2198bd9

@zalves
Copy link
zalves commented Jan 8, 2025

Just today I had to build a firmware for my ESP32C3 super mini to use with an INMP441 mic. Works great!

@@ -4,7 +4,7 @@
#define MICROPY_HW_MCU_NAME "ESP32C3"

#define MICROPY_HW_ENABLE_SDCARD (0)
#define MICROPY_PY_MACHINE_I2S (0)
#define MICROPY_PY_MACHINE_I2S (1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just remove this line altogether. Then it should pick up the default config, which is to enable I2S.

@@ -3,7 +3,7 @@
#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "mpy-c3-mini"

#define MICROPY_HW_ENABLE_SDCARD (0)
#define MICROPY_PY_MACHINE_I2S (0)
#define MICROPY_PY_MACHINE_I2S (1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, just remove this line.

Signed-off-by: StrayCat <marcin.eu@gmail.com>
Signed-off-by: StrayCat <marcin.eu@gmail.com>
@dpgeorge
Copy link
Member
dpgeorge commented Feb 8, 2025

Squashed, rebased and merged in 9d0a5ac

@dpgeorge dpgeorge closed this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0