esp32/boards/LOLIN_C3_MINI/mpconfigboard.h: Enabled i2s.#16516
esp32/boards/LOLIN_C3_MINI/mpconfigboard.h: Enabled i2s.#16516StrayCatNZ wants to merge 4 commits intomicropython:masterfrom
Conversation
Signed-off-by: StrayCat <marcin.eu@gmail.com>
|
This should maybe be on all ESP32C3 devices? I do not see any reason why this feature would be board specific? |
Most likely yes, I can also change it in generic c3. I only have esp32c3 supermini to test it on though, if you think that will be enough of a test? |
|
If you only have one, that is ok. Hopefully one other person is able to test on another C3! That would be ideal :) |
Signed-off-by: StrayCat <marcin.eu@gmail.com>
I also flashed ESP32_GENERIC_C3 version into my esp32c3 mini and i2s works with this firmware too. So far I'm using my esp32c3 mini with this patch in a project where it plays audio with i2s, controls some leds and communicates with lego hub at the same time and no issues so far, so super happy about that! :) |
|
Just today I had to build a firmware for my ESP32C3 super mini to use with an INMP441 mic. Works great! |
|
|
||
| #define MICROPY_HW_ENABLE_SDCARD (0) | ||
| #define MICROPY_PY_MACHINE_I2S (0) | ||
| #define MICROPY_PY_MACHINE_I2S (1) |
There was a problem hiding this comment.
Please just remove this line altogether. Then it should pick up the default config, which is to enable I2S.
|
|
||
| #define MICROPY_HW_ENABLE_SDCARD (0) | ||
| #define MICROPY_PY_MACHINE_I2S (0) | ||
| #define MICROPY_PY_MACHINE_I2S (1) |
There was a problem hiding this comment.
As above, just remove this line.
Signed-off-by: StrayCat <marcin.eu@gmail.com>
Signed-off-by: StrayCat <marcin.eu@gmail.com>
|
Squashed, rebased and merged in 9d0a5ac |
Summary
Enabled i2s for lolin_c3_mini as it works fine now.
Testing
Tested on esp32_c3_SuperMini and it works great!