ports/rp2: Add a means to set mass-storage filesystem label #13470
Conversation
|
Code size report: |
a646062 to
b13e701
Compare
Signed-off-by: Phil Howard <github@gadgetoid.com>
Set the USB mass storage label when the filesystem is created. Signed-off-by: Phil Howard <github@gadgetoid.com>
b13e701 to
5131dbd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #13470 +/- ##
==========================================
- Coverage 98.36% 98.35% -0.01%
==========================================
Files 159 159
Lines 21088 21090 +2
==========================================
Hits 20743 20743
- Misses 345 347 +2 ☔ View full report in Codecov by Sentry. |
|
I'm not sure that this is the best way to do it, because it adds a method, code size, and differs to other Vfs filesystems that don't support a label. How about instead copy the way the stm32 port does it, have a |
|
As it stands, you're probably right and I'll refactor this PR to fix the omission without addressing our specific use-case- I've got a fork with some minimal changes that allow USB Mass Storage mode builds to expose two filesystems (currently hard-coded, but then the whole USB MSC thing is a bit of an exception to the do-everything-USB-in-Python goal at the moment). In our - admittedly quite contrived - demo case, these two filesystems have distinct labels. The conceit is that we can have one filesystem that's writable from MicroPython, and one that's writeable from the host and use the formere as a means to support logging, saves, config changes and so forth while code is written into the latter from the host. Of course this is all highly experimental but it works and suggests there might be scope for some more esoteric FAT/MSC builds if we find the experience... tolerable. I am keenly aware of all the problems with filesystem syncing across multiple hosts from my tinkering with PiratePython (a CPython RAMdisk for Pi Zero). It might be that MicroPython is unconcerned with the slippery slope that is FAT/MSC and the answer is for us to build our own C module to implement this functionality (ala the Factory Reset style of some ports). I'm happy with that. (on the off chance anyone wants to replicate this dual FS weirdness, diff here - master...pimoroni:micropython:feature/multi-msc) |
|
This is an automated heads-up that we've just merged a Pull Request See #13763 A search suggests this PR might apply the STATIC macro to some C code. If it Although this is an automated message, feel free to @-reply to me directly if |
This addresses discussion over at https://github.com/orgs/micropython/discussions/9590
For other boards which more conventionally use MSC, they call
f_setlabelfrom the factory reset code paths in C, eg:micropython/ports/renesas-ra/factoryreset.c
Line 88 in 16c6bc4
The C method uses
MICROPY_HW_FLASH_FS_LABEL, but I wasn't sure by what means we could incorporate that into RP2's Python filesystem bootstrapping. Perhaps callingvfs.label()without an argument could use this as the default value?