8000 esp32/boards: Add support for XIAO ESP32S3/C3 boards. by Maxwelltoo · Pull Request #12042 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

esp32/boards: Add support for XIAO ESP32S3/C3 boards. #12042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

esp32/boards: Add support for XIAO ESP32S3/C3 boards. #12042

wants to merge 3 commits into from
+150 −0

Conversation

Maxwelltoo
Copy link

No description provided.

@Maxwelltoo Maxwelltoo force-pushed the master branch 2 times, most recently from 5d64b97 to 9be6a2b Compare July 19, 2023 08:14
@Maxwelltoo
Copy link
Author

Where should I add pictures of these boards?

@mcauser
Copy link
Contributor
mcauser commented Jul 19, 2023

Where should I add pictures of these boards?

https://github.com/micropython/micropython-media

@sosi-deadeye
Copy link
10000

Is there a reason why I2S is deactivated? I use I2S with the ESP32C3.

@ricksorensen
Copy link
Contributor

@sosi-deadeye Do you hava a working I2S with ESP32C3 and the 1.20.0 machine_i2s.c? I am not particularly skillful with I2S and have only used it for audio out, but I had to modify the source to get a static free output from I2S. See #11245 and https://github.com/orgs/micropython/discussions/11178 for example. With these modifications I have I2S outputing correctly for my small subset of uses, with IDV v5.0.

pavelrevak
pavelrevak reviewed Aug 17, 2023
View reviewed changes
ports/esp32/boards/XIAO_ESP32C3/modules/xiao.py Outdated
# XIAO ESP32 C3 MicroPython Helper Library

from micropython import const
from machine import Pin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove unused import

@ricksorensen
Copy link
Contributor

Should the board name include manufacturer? See samd/ports/SEEED_XIAO_SAMD21 for example. If so it could be:
SEEED_XIAO_ESP32C3

@Maxwelltoo
esp32/boards: Add support for XIAO ESP32C3 boards.
1758dc7 
Signed-off-by: Jiaxuan Weng <1391548050@qq.com>
@Maxwelltoo
esp32/boards: Add support for XIAO ESP32S3 boards.
7035267 
Signed-off-by: Jiaxuan Weng <1391548050@qq.com>
@Maxwelltoo
esp32/boards: Add manufacturer to board name and remove unused import.
2a55a3f 
Signed-off-by: Jiaxuan Weng <1391548050@qq.com>
@Maxwelltoo
Copy link
Author

Should the board name include manufacturer? See samd/ports/SEEED_XIAO_SAMD21 for example. If so it could be: SEEED_XIAO_ESP32C3

You are right. now manufacturer name has been added to the board name.

@mattytrentini mattytrentini added the board-definition New or updated board definition files. Combine with a port- label. label Oct 10, 2023
@pavelrevak
Copy link

Just tested this PR and is still working with latest master, is there any plan to merge it?

@cnadler86
Copy link

Is this still ongoing? I am preparing a PR that needs Xiao S3 support.

cnadler86
cnadler86 reviewed Aug 31, 2024
View reviewed changes
ports/esp32/boards/SEEED_XIAO_ESP32S3/mpconfigboard.cmake
Copy link
A7A2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here you should also add spiram_oct to support octal. Have you tested de ram size with your configuration?

@cnadler86 cnadler86 mentioned this pull request Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelrevak pavelrevak pavelrevak left review comments

@cnadler86 cnadler86 cnadler86 left review comments

Assignees
No one assigned
Labels
board-definition New or updated board definition files. Combine with a port- label. port-esp32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Maxwelltoo @mcauser @sosi-deadeye @ricksorensen @pavelrevak @cnadler86 @mattytrentini @dpgeorge
0