8000 dict functions are missing from dynruntime.h · Issue #5609 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

dict functions are missing from dynruntime.h #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeremyherbert opened this issue Feb 5, 2020 · 3 comments
Closed

dict functions are missing from dynruntime.h #5609

jeremyherbert opened this issue Feb 5, 2020 · 3 comments
Labels
py-core Relates to py/ directory in source

Comments

@jeremyherbert
Copy link
Contributor

In dynruntime.h, mp_obj_new_dict and mp_obj_dict_store are not defined, whereas mp_obj_new_list and mp_obj_list_append are. Was this deliberate or an oversight?
@dpgeorge
Copy link
Member
dpgeorge commented Feb 5, 2020

It was mostly API functions that were needed by the examples in examples/natmod that were initially added. There's no problem at all to add more API functions.

@dpgeorge dpgeorge added the py-core Relates to py/ directory in source label Feb 5, 2020
@jeremyherbert
Copy link
Contributor Author

Ok, I will add and PR soon.

@jeremyherbert jeremyherbert mentioned this issue Feb 14, 2020
Closed
tannewt pushed a commit to tannewt/circuitpython that referenced this issue Dec 2, 2021
@jepler
Update ulab to 3.3.7
1b87d2b 
Closes: micropython#5609
@dpgeorge
Copy link
Member

Dict functions were added in 148d122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
py-core Relates to py/ directory in source
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremyherbert @dpgeorge
0