8000 Add EINTR to uerrno module? · Issue #3327 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

Add EINTR to uerrno module? #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dlech opened this issue Sep 22, 2017 · 6 comments
Closed

Add EINTR to uerrno module? #3327

dlech opened this issue Sep 22, 2017 · 6 comments

Comments

@dlech
Copy link
Contributor
dlech commented Sep 22, 2017

This error is common on Unix platforms. Just wanted to ask if it would be worth adding to the uerrno module before submitting a pull request. EINTR already is available via the errno module in micropython-lib.
@pfalcon
Copy link
Contributor
pfalcon commented Sep 23, 2017

There're ~200 errors common on Unix platforms. Please read https://github.com/micropython/micropython/wiki/ContributorGuidelines and feel free to provide arguments why EINTR is unavoidable useful (especially that in upstream Python 3.6 users would never see it).

@dlech
Copy link
Contributor Author
dlech commented Sep 23, 2017

Since pretty much all system calls can be interrupted by a signal which results in this error, it seems more common than the others. Since I can use errno micropython-lib, this isn't a blocker for me, but I just wanted to through it out there to see if anyone else had a need too. If I'm the only one, then there isn't really a compelling reason to add it.

@pfalcon
Copy link
Contributor
pfalcon commented Sep 23, 2017

Since I can use errno micropython-lib

That's the recommended way indeed.

@dpgeorge
Copy link
Member

Ideally EINTR wouldn't filter through because of PEP 475 (which isn't yet implemented in uPy). See #1329 and #3268 for further reading.

@dlech
Copy link
Contributor Author
dlech commented Sep 25, 2017

Thanks. In that case, I'm closing in favor of #3268 / PEP 475.

@dlech dlech closed this as completed Sep 25, 2017
@dlech
Copy link
Contributor Author
dlech commented Mar 5, 2020

PEP 475 implemented in #5723

@BryanSouza91 BryanSouza91 mentioned this issue Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pfalcon @dlech @dpgeorge
0