8000 mp_sched_schedule's scheduled callbacks don't run on empty REPL lines · Issue #3273 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

mp_sched_schedule's scheduled callbacks don't run on empty REPL lines #3273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pfalcon opened this issue Aug 15, 2017 · 7 comments
Closed

mp_sched_schedule's scheduled callbacks don't run on empty REPL lines #3273

pfalcon opened this issue Aug 15, 2017 · 7 comments
Assignees
@dpgeorge
Labels
port-zephyr

Comments

@pfalcon
Copy link
Contributor
pfalcon commented Aug 15, 2017

Ok, so using mp_sched_schedule() with interactive REPL is problematic - scheduled stuff won't run until REPL executes something. That's understood. However, it would be nice if empty lines entered actually caused them to be executed. Otherwise, it requires really dirty workaround of typing random expressions to get it going, like me typing 1 below:

>>> conn.gatt_read(3, print)
>>> read_cb: 0
4d 49 

>>> 1
b'MI'
1
>>> 1
1
>>> conn.gatt_read(5, print)
>>> read_cb: 0
00 00 

>>> 1
b'\x00\x00'
1
>>> conn.gatt_read(7, print)
>>> read_cb: 0
00 

>>> 
>>> 1
b'\x00'
1
>>> conn.gatt_read(9, print)
>>> read_cb: 0
06 00 50 00 00 00 f4 01 

>>> 1
b'\x06\x00P\x00\x00\x00\xf4\x01'
1
@dpgeorge
Copy link
Member

What platform/port do you use? It's generally up to the port to make this behave correctly and IIRC it works OK on esp8266 and pyboard. If you could give minimal code that reproduces the error that would help.

@pfalcon
Copy link
Contributor Author
pfalcon commented Aug 16, 2017

It's Zephyr port, and my first attempt to use mp_sched_schedule() at all. There's no immediate way to reproduce the above (it's prototype of BLE module). I'll look into what stmhal/esp8266 do, but from the above I can imagine that probably lexer detects that input string is empty and doesn't call VM. It could at least signal it to process scheduled callbacks in this case, and that would be port-independent.

@dpgeorge
Copy link
Member

I'll look into what stmhal/esp8266 do,

They call mp_handle_pending() in their MICROPY_EVENT_POLL_HOOK macro, which is in turn called from the busy-wait loop when waiting for incoming chars for the REPL. With this approach, scheduled callbacks will be called while waiting for a uselect.poll.poll() call, for example.

@pfalcon
Copy link
Contributor Author
pfalcon commented Aug 16, 2017

Thanks, will look into adding that.

tannewt pushed a commit to tannewt/circuitpython that referenced this issue Aug 14, 2020
@dhalbert
Merge pull request micropython#3273 from jepler/ja-firmware-size
a28d0f6 
Squeeze firmwares to fit the new ja translation
@dpgeorge
Copy link
Member 8000

This behaviour of mp_sched_schedule() is intended, so closing.

@dpgeorge
Copy link
Member

Ah, this didn't get closed... anyway, with #7177 scheduled events will be run asynchronously at the REPL and during sleeps.

@dpgeorge
Copy link
Member

Now works via d120859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpgeorge dpgeorge

Labels
port-zephyr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pfalcon @dpgeorge
0