esp32: Pin MicroPython to core 1 again.

breedx2 · breedx2 · commit c20cfb10e0a8 · 2021-05-12T21:10:06.000-07:00
This follows up on #5489, where we changed the esp32 core pinning to core 0 in order to work around an issue with IDF < 4.2.0. Now that IDF > 4.2.0 is available, we allow pinning back to core 1, which eliminates some problematic callback latency with wifi enabled.
diff --git a/ports/esp32/mphalport.h b/ports/esp32/mphalport.h
@@ -36,10 +36,15 @@
 #include "freertos/task.h"
 
 // The core that the MicroPython task(s) are pinned to.
-// Until we move to IDF 4.2+, we need NimBLE on core 0, and for synchronisation
-// with the ringbuffer and scheduler MP needs to be on the same core.
-// See https://github.com/micropython/micropython/issues/5489
+// Now that we have IDF 4.2.0+, we are once again able to pin to core 1
+// and avoid the Wifi/BLE timing problems on the same core.
+// Best effort here to remain backwards compatible in rare version edge cases...
+// See https://github.com/micropython/micropython/issues/5489 for history
+#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(4, 2, 0)
+#define MP_TASK_COREID (1)
+#else
 #define MP_TASK_COREID (0)
+#endif
 
 extern TaskHandle_t mp_main_task_handle;
 
