esp32/network_ppp: Block after deleting task.

DvdGiessen · dpgeorge · commit c0d4c604e6a1 · 2023-09-02T18:01:03.000+10:00
When calling ppp.active(False) we could get a crash due to immediately
returning after asking FreeRTOS to delete the current task.

This commit adds a simple blocking loop, the same as used in all other
places where we call vTaskDelete(NULL).

Signed-off-by: Daniël van de Giessen &lt;daniel@dvdgiessen.nl&gt;
diff --git a/ports/esp32/network_ppp.c b/ports/esp32/network_ppp.c
@@ -114,6 +114,8 @@ static void pppos_client_task(void *self_in) {
 
     self->client_task_handle = NULL;
     vTaskDelete(NULL);
+    for (;;) {
+    }
 }
 
 STATIC mp_obj_t ppp_active(size_t n_args, const mp_obj_t *args) {

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,8 @@ static void pppos_client_task(void *self_in) {`
`114`	`114`
`115`	`115`	`self->client_task_handle = NULL;`
`116`	`116`	`vTaskDelete(NULL);`
	`117`	`+ for (;;) {`
	`118`	`+ }`
`117`	`119`	`}`
`118`	`120`
`119`	`121`	`STATIC mp_obj_t ppp_active(size_t n_args, const mp_obj_t *args) {`