pyboard: Fix espxx boards hanging in bootloader after reset button.

Josverl · Josverl · commit 9f5c97c84c2e · 2023-03-19T21:42:56.000Z
Signed-off-by: Jos Verlinde &lt;jos_verlinde@hotmail.com&gt;
diff --git a/tools/pyboard.py b/tools/pyboard.py
@@ -287,11 +287,15 @@ def __init__(
             for attempt in range(wait + 1):
                 try:
                     if os.name == "nt":
-                        # Windows does not set DTR or RTS by default
                         self.serial = serial.Serial(**serial_kwargs)
-                        self.serial.dtr = True
-                        self.serial.rts = False
                         self.serial.port = device
+                        portinfo = list(serial.tools.list_ports.grep(device))  # type: ignore
+                        if portinfo and portinfo[0].manufacturer != "Microsoft":
+                            # ESPxx boards and ESP32 boards use RTS/CTS for flashing and boot mode selection
+                            # DTR False, to avoid using the reset button will hang the MCU in bootloader mode
+                            # RTS False, to prevent pulses on rts on serial.close() that would POWERON_RESET an ESPxx
+                            self.serial.dtr = False  # DTR False = gpio0 High = Normal boot
+                            self.serial.rts = False  # RTS False = EN High = MCU enabled
                         self.serial.open()
                     else:
                         self.serial = serial.Serial(device, **serial_kwargs)
