extmod/modlwip: Codestyle: no need for () when taking address of primary expr.

Paul Sokolovsky · Paul Sokolovsky · commit 858ed6d2f7ea · 2015-10-27T01:39:57.000+03:00
Like foo.bar or foo-&gt;bar.
diff --git a/extmod/modlwip.c b/extmod/modlwip.c
@@ -116,7 +116,7 @@ STATIC mp_obj_t lwip_slip_make_new(mp_obj_t type_in, mp_uint_t n_args, mp_uint_t
         nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "not a valid remote IP"));
     }
 
-    struct netif *n = &(lwip_slip_obj.lwip_netif);
+    struct netif *n = &lwip_slip_obj.lwip_netif;
     if (netif_add(n, &iplocal, IP_ADDR_BROADCAST, &ipremote, NULL, slipif_init, ip_input) == NULL) {
        nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "out of memory"));
     }
@@ -214,7 +214,7 @@ STATIC void _lwip_udp_incoming(void *arg, struct udp_pcb *upcb, struct pbuf *p,
     } else {
         socket->incoming = (void*)p;
         socket->peer_port = (mp_uint_t)port;
-        memcpy(&(socket->peer), addr, 4);
+        memcpy(&socket->peer, addr, 4);
     }
 }
 
@@ -339,7 +339,7 @@ STATIC mp_uint_t lwip_udp_receive(lwip_socket_obj_t *socket, byte *buf, mp_uint_
     }
 
     if (ip != NULL) {
-        memcpy(ip, &(socket->peer), 4);
+        memcpy(ip, &socket->peer, 4);
         *port = socket->peer_port;
     }
 
@@ -815,7 +815,7 @@ STATIC mp_obj_t lwip_socket_recvfrom(mp_obj_t self_in, mp_obj_t len_in) {
     mp_uint_t ret = 0;
     switch (socket->type) {
         case MOD_NETWORK_SOCK_STREAM: {
-            memcpy(ip, &(socket->peer), 4);
+            memcpy(ip, &socket->peer, 4);
             port = (mp_uint_t) socket->peer_port;
             ret = lwip_tcp_receive(socket, (byte*)vstr.buf, len, &_errno);
             break;

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ STATIC mp_obj_t lwip_slip_make_new(mp_obj_t type_in, mp_uint_t n_args, mp_uint_t`
`116`	`116`	`nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "not a valid remote IP"));`
`117`	`117`	`}`
`118`	`118`
`119`		`- struct netif *n = &(lwip_slip_obj.lwip_netif);`
	`119`	`+ struct netif *n = &lwip_slip_obj.lwip_netif;`
`120`	`120`	`if (netif_add(n, &iplocal, IP_ADDR_BROADCAST, &ipremote, NULL, slipif_init, ip_input) == NULL) {`
`121`	`121`	`nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "out of memory"));`
`122`	`122`	`}`
`@@ -214,7 +214,7 @@ STATIC void _lwip_udp_incoming(void arg, struct udp_pcb upcb, struct pbuf *p,`
`214`	`214`	`} else {`
`215`	`215`	`socket->incoming = (void*)p;`
`216`	`216`	`socket->peer_port = (mp_uint_t)port;`
`217`		`- memcpy(&(socket->peer), addr, 4);`
	`217`	`+ memcpy(&socket->peer, addr, 4);`
`218`	`218`	`}`
`219`	`219`	`}`
`220`	`220`
`@@ -339,7 +339,7 @@ STATIC mp_uint_t lwip_udp_receive(lwip_socket_obj_t socket, byte buf, mp_uint_`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`if (ip != NULL) {`
`342`		`- memcpy(ip, &(socket->peer), 4);`
	`342`	`+ memcpy(ip, &socket->peer, 4);`
`343`	`343`	`*port = socket->peer_port;`
`344`	`344`	`}`
`345`	`345`
`@@ -815,7 +815,7 @@ STATIC mp_obj_t lwip_socket_recvfrom(mp_obj_t self_in, mp_obj_t len_in) {`
`815`	`815`	`mp_uint_t ret = 0;`
`816`	`816`	`switch (socket->type) {`
`817`	`817`	`case MOD_NETWORK_SOCK_STREAM: {`
`818`		`- memcpy(ip, &(socket->peer), 4);`
	`818`	`+ memcpy(ip, &socket->peer, 4);`
`819`	`819`	`port = (mp_uint_t) socket->peer_port;`
`820`	`820`	`ret = lwip_tcp_receive(socket, (byte*)vstr.buf, len, &_errno);`
`821`	`821`	`break;`