esp32/esp32_rmt: Fix looping behaviour for RMT on ESP32-S3.

IcedRooibos · dpgeorge · commit 7ea06a3e2638 · 2023-04-26T12:32:13.000+10:00
The previous code worked on ESP32 but not ESP32-S3.  All the IDF (v4.4.3)
examples call rmt_set_tx_loop_mode before rmt_write_items, so make that
change here.

Signed-off-by: Damien George &lt;damien@micropython.org&gt;
diff --git a/ports/esp32/esp32_rmt.c b/ports/esp32/esp32_rmt.c
@@ -326,13 +326,13 @@ STATIC mp_obj_t esp32_rmt_write_pulses(size_t n_args, const mp_obj_t *args) {
         check_esp_err(rmt_wait_tx_done(self->channel_id, portMAX_DELAY));
     }
 
-    check_esp_err(rmt_write_items(self->channel_id, self->items, num_items, false));
-
     if (self->loop_en) {
         check_esp_err(rmt_set_tx_intr_en(self->channel_id, false));
         check_esp_err(rmt_set_tx_loop_mode(self->channel_id, true));
     }
 
+    check_esp_err(rmt_write_items(self->channel_id, self->items, num_items, false));
+
     return mp_const_none;
 }
 STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(esp32_rmt_write_pulses_obj, 2, 3, esp32_rmt_write_pulses);

Original file line number	Diff line number	Diff line change
`@@ -326,13 +326,13 @@ STATIC mp_obj_t esp32_rmt_write_pulses(size_t n_args, const mp_obj_t *args) {`
`326`	`326`	`check_esp_err(rmt_wait_tx_done(self->channel_id, portMAX_DELAY));`
`327`	`327`	`}`
`328`	`328`
`329`		`- check_esp_err(rmt_write_items(self->channel_id, self->items, num_items, false));`
`330`		`-`
`331`	`329`	`if (self->loop_en) {`
`332`	`330`	`check_esp_err(rmt_set_tx_intr_en(self->channel_id, false));`
`333`	`331`	`check_esp_err(rmt_set_tx_loop_mode(self->channel_id, true));`
`334`	`332`	`}`
`335`	`333`
	`334`	`+ check_esp_err(rmt_write_items(self->channel_id, self->items, num_items, false));`
	`335`	`+`
`336`	`336`	`return mp_const_none;`
`337`	`337`	`}`
`338`	`338`	`STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(esp32_rmt_write_pulses_obj, 2, 3, esp32_rmt_write_pulses);`