nrf/soft_pwm: Ensure duty_width can't be used uninitialised.

pi-anl · pi-anl · commit 139fcd1876ec · 2024-06-07T11:15:31.000+10:00
Signed-off-by: Andrew Leech &lt;andrew@alelec.net&gt;
diff --git a/ports/nrf/modules/machine/soft_pwm.c b/ports/nrf/modules/machine/soft_pwm.c
@@ -199,6 +199,8 @@ static void machine_soft_pwm_start(machine_pwm_obj_t *self) {
             duty_width = self->duty * DUTY_FULL_SCALE / 65536;
         } else if (self->duty_mode == DUTY_NS) {
             duty_width = (uint64_t)self->duty * self->freq * DUTY_FULL_SCALE / 1000000000ULL;
+        } else {
+            mp_raise_ValueError(MP_ERROR_TEXT("invalid duty mode"));
         }
         pwm_set_duty_cycle(self->pwm_pin, duty_width);
     }

Original file line number	Diff line number	Diff line change
`@@ -199,6 +199,8 @@ static void machine_soft_pwm_start(machine_pwm_obj_t *self) {`
`199`	`199`	`duty_width = self->duty * DUTY_FULL_SCALE / 65536;`
`200`	`200`	`} else if (self->duty_mode == DUTY_NS) {`
`201`	`201`	`duty_width = (uint64_t)self->duty * self->freq * DUTY_FULL_SCALE / 1000000000ULL;`
	`202`	`+ } else {`
	`203`	`+ mp_raise_ValueError(MP_ERROR_TEXT("invalid duty mode"));`
`202`	`204`	`}`
`203`	`205`	`pwm_set_duty_cycle(self->pwm_pin, duty_width);`
`204`	`206`	`}`