Merge pull request adafruit#5373 from lesamouraipourpre/fill-row

microdev1 · web-flow · commit 279d0d64fed0 · 2021-09-20T01:47:09.000+05:30
Update Display.fill_row() to accept all WriteableBuffers
diff --git a/shared-bindings/displayio/Display.c b/shared-bindings/displayio/Display.c
@@ -467,9 +467,6 @@ STATIC mp_obj_t displayio_display_obj_fill_row(size_t n_args, const mp_obj_t *po
     mp_buffer_info_t bufinfo;
     mp_get_buffer_raise(result, &bufinfo, MP_BUFFER_WRITE);
 
-    if (bufinfo.typecode != BYTEARRAY_TYPECODE) {
-        mp_raise_ValueError(translate("Buffer is not a bytearray."));
-    }
     if (self->core.colorspace.depth != 16) {
         mp_raise_ValueError(translate("Display must have a 16 bit colorspace."));
     }

Original file line number	Diff line number	Diff line change
`@@ -467,9 +467,6 @@ STATIC mp_obj_t displayio_display_obj_fill_row(size_t n_args, const mp_obj_t *po`
`467`	`467`	`mp_buffer_info_t bufinfo;`
`468`	`468`	`mp_get_buffer_raise(result, &bufinfo, MP_BUFFER_WRITE);`
`469`	`469`
`470`		`- if (bufinfo.typecode != BYTEARRAY_TYPECODE) {`
`471`		`- mp_raise_ValueError(translate("Buffer is not a bytearray."));`
`472`		`- }`
`473`	`470`	`if (self->core.colorspace.depth != 16) {`
`474`	`471`	`mp_raise_ValueError(translate("Display must have a 16 bit colorspace."));`
`475`	`472`	`}`