8000 Fix compilation with --with-bsd-auth. · micdev42/postgres@866490a · GitHub
[go: up one dir, main page]
Skip to content
{"payload":{"commit":{"oid":"866490a6b72c625c29ced23065d367a1b0484760","url":"/micdev42/postgres/commit/866490a6b72c625c29ced23065d367a1b0484760","authoredDate":"2017-05-19T12:21:55.000+03:00","committedDate":"2017-05-19T12:21:55.000+03:00","shortMessage":null,"shortMessageMarkdown":"\u003cdiv\u003eFix compilation with --with-bsd-auth.\u003c/div\u003e","shortMessageMarkdownLink":null,"bodyMessageHtml":"Commit \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/micdev42/postgres/commit/8d3b9cce81c173da55b9500353e5d773f8449a66/hovercard\" href=\"https://github.com/micdev42/postgres/commit/8d3b9cce81c173da55b9500353e5d773f8449a66\"\u003e\u003ctt\u003e8d3b9cc\u003c/tt\u003e\u003c/a\u003e added extra arguments to the sendAuthRequest function,\nbut neglected this caller inside #ifdef USE_BSD_AUTH.\n\nPer report from Pierre-Emmanuel André.\n\nDiscussion: \u003ca href=\"https://www.postgresql.org/message-id/20170519090336.whzmjzrsap6ktbgg@digipea.digitick.local\" rel=\"nofollow\"\u003ehttps://www.postgresql.org/message-id/20170519090336.whzmjzrsap6ktbgg@digipea.digitick.local\u003c/a\u003e","authors":[{"login":"hlinnaka","displayName":"Heikki Linnakangas","avatarUrl":"https://avatars.githubusercontent.com/u/191602?v=4","path":"/hlinnaka","isGitHub":false}],"committerAttribution":false,"committer":{"login":"hlinnaka","displayName":"Heikki Linnakangas","avatarUrl":"https://avatars.githubusercontent.com/u/191602?v=4","path":"/hlinnaka","isGitHub":false},"parents":["f4205c4c1fcfc88d0c3885c160f24873bcbcc04d"],"globalRelayId":"MDY6Q29tbWl0OTIyNDg2MDE6ODY2NDkwYTZiNzJjNjI1YzI5Y2VkMjMwNjVkMzY3YTFiMDQ4NDc2MA==","sha1":"f4205c4c1fcfc88d0c3885c160f24873bcbcc04d","sha2":"866490a6b72c625c29ced23065d367a1b0484760"},"currentUser":null,"repo":{"id":92248601,"defaultBranch":"master","name":"postgres","ownerLogin":"micdev42","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2017-05-24T04:07:08.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1901776?v=4","public":true,"private":false,"isOrgOwned":false},"diffEntryData":[{"diffLines":[{"stylingDirective":null,"type":"HUNK","blobLineNumber":2261,"text":"@@ -2262,7 +2262,7 @@ CheckBSDAuth(Port *port, char *user)","html":"@@ -2262,7 +2262,7 @@ CheckBSDAuth(Port *port, char *user)","displayNoNewLineWarning":false,"position":0,"left":2261,"right":2261},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":2262,"text":" \tint\t\t\tretval;","html":" \t\u003cspan class=pl-smi\u003eint\u003c/span\u003e\t\t\t\u003cspan class=pl-s1\u003eretval\u003c/span\u003e;","displayNoNewLineWarning":false,"position":1,"left":2262,"right":2262},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":2263,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":2,"left":2263,"right":2263},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":2264,"text":" \t/* Send regular password request to client, and get the response */","html":" \t\u003cspan class=pl-c\u003e/* Send regular password request to client, and get the response */\u003c/span\u003e","displayNoNewLineWarning":false,"position":3,"left":2264,"right":2264},{"stylingDirective":null,"type":"DELETION","blobLineNumber":2265,"text":"-\tsendAuthRequest(port, AUTH_REQ_PASSWORD);","html":"-\t\u003cspan class=\"pl-en\"\u003esendAuthRequest\u003c/span\u003e(\u003cspan class=\"pl-s1\"\u003eport\u003c/span\u003e, \u003cspan class=\"pl-c1\"\u003eAUTH_REQ_PASSWORD\u003c/span\u003e);","displayNoNewLineWarning":false,"position":4,"left":2265,"right":2264},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":2265,"text":"+\tsendAuthRequest(port, AUTH_REQ_PASSWORD, NULL, 0);","html":"+\t\u003cspan class=\"pl-en\"\u003esendAuthRequest\u003c/span\u003e(\u003cspan class=\"pl-s1\"\u003eport\u003c/span\u003e, \u003cspan class=\"pl-c1\"\u003eAUTH_REQ_PASSWORD\u003c/span\u003e\u003cspan class=\"x x-first\"\u003e, \u003c/span\u003e\u003cspan class=\"pl-c1 x\"\u003eNULL\u003c/span\u003e\u003cspan class=\"x\"\u003e, \u003c/span\u003e\u003cspan class=\"pl-c1 x x-last\"\u003e0\u003c/span\u003e);","displayNoNewLineWarning":false,"position":5,"left":2265,"right":2265},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":2266,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":6,"left":2266,"right":2266},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":2267,"text":" \tpasswd = recv_password_packet(port);","html":" \t\u003cspan class=pl-s1\u003epasswd\u003c/span\u003e \u003cspan class=pl-c1\u003e=\u003c/span\u003e \u003cspan class=pl-en\u003erecv_password_packet\u003c/span\u003e(\u003cspan class=pl-s1\u003eport\u003c/span\u003e);","displayNoNewLineWarning":false,"position":7,"left":2267,"right":2267},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":2268,"text":" \tif (passwd == NULL)","html":" \t\u003cspan class=pl-k\u003eif\u003c/span\u003e (\u003cspan class=pl-s1\u003epasswd\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-c1\u003eNULL\u003c/span\u003e)","displayNoNewLineWarning":false,"position":8,"left":2268,"right":2268}],"diffNumber":0,"diffSize":"0 Bytes","isBinary":false,"isTooBig":false,"collapsed":false,"isSubmodule":false,"lineCount":3114,"linesChanged":2,"newTreeEntry":{"lineCount":3114,"path":"src/backend/libpq/auth.c","mode":100644,"isGenerated":false},"oldTreeEntry":{"lineCount":0,"path":"src/backend/libpq/auth.c","mode":100644},"linesAdded":1,"linesDeleted":1,"path":"src/backend/libpq/auth.c","pathDigest":"f7b3586e5625122376793d34b3ca05b199c0d34ef808b3fed72bf8d981a8b3af","status":"MODIFIED","truncatedReason":null,"oldOid":"f4205c4c1fcfc88d0c3885c160f24873bcbcc04d","newOid":"866490a6b72c625c29ced23065d367a1b0484760","copilotChatReference":null,"deletedSha":"f4205c4c1fcfc88d0c3885c160f24873bcbcc04d","canToggleRichDiff":false,"defaultToRichDiff":false,"proseDifffHtml":null,"renderInfo":null,"dependencyDiffPath":null,"submodule":null}],"splitViewPreference":"unified","ignoreWhitespace":false,"commentsPreference":"visible","diffLineSpacingPreference":"relaxed","useMonospaceFont":false,"pasteUrlLinkAsPlainText":false,"userNotices":[],"path":"/micdev42/postgres/commit/866490a6b72c625c29ced23065d367a1b0484760","fileTreeExpanded":true,"headerInfo":{"additions":1,"deletions":1,"filesChanged":1,"filesChangedString":"1"},"moreDiffsToLoad":false,"asyncDiffLoadInfo":{"startIndex":1,"truncated":false,"byteCount":306,"lineShownCount":9},"commentInfo":{"canComment":false,"locked":false,"canLock":false,"repoArchived":false},"csrf_tokens":{"/users/diffview?diff=split":{"post":"y6ctPk5-5ot-_q76MLzT5EBJjZVIcu5CAA69v17JqInToKgzNygMbArTdGtLPGpSbvMW7bSh-qUfXZCFUv7boA"},"/users/diffview?diff=unified":{"post":"qvcCH7Y8vzfng4FIpIxrkUWyol-X0w_dQOB8FsNlZYyy8IcSz2pV0JOuW9nfDNInawg5J2sAGzpfs1Esz1IWpQ"},"/notifications/thread":{"post":"wK6CMwSg8O3gh3T_-1wsOlwGLZPe_9GNw5_oYTwnb3Cix3QDbr0X8YOw5I6lciBXLcOaWnIz8Ho70NSJ8a-aQA"}}},"title":"Fix compilation with --with-bsd-auth. · micdev42/postgres@866490a","appPayload":{"helpUrl":"https://docs.github.com","findInDiffWorkerPath":"/assets-cdn/worker/find-in-diff-worker-6dcb06aa9fad.js","enabled_features":{"diff_ux_refresh_beta":false,"diff_inline_comments":false,"diff_ux_refresh_ssr_five":false,"diff_ux_refresh_ssr_ten":false}}}

Commit 866490a

Browse files
hlinnakahlinnaka
committed
Fix compilation with --with-bsd-auth.
Commit 8d3b9cc added extra arguments to the sendAuthRequest function, but neglected this caller inside #ifdef USE_BSD_AUTH. Per report from Pierre-Emmanuel André. Discussion: https://www.postgresql.org/message-id/20170519090336.whzmjzrsap6ktbgg@digipea.digitick.local
1 parent f4205c4 commit 866490a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/backend/libpq/auth.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2262,7 +2262,7 @@ CheckBSDAuth(Port *port, char *user)
22622262
int retval;
22632263

22642264
/* Send regular password request to client, and get the response */
2265-
sendAuthRequest(port, AUTH_REQ_PASSWORD);
2265+
sendAuthRequest(port, AUTH_REQ_PASSWORD, NULL, 0);
22662266

22672267
passwd = recv_password_packet(port);
22682268
if (passwd == NULL)

0 commit comments

Comments
 (0)
0