Fix pg_resetxlog to use correct path to postmaster.pid.

tglsfdc · tglsfdc · commit 336bc0dff20e · 2012-11-22T11:23:46.000-05:00
Since we've already chdir'd into the data directory, the file should be referenced as just "postmaster.pid", without prefixing the directory path. This is harmless in the normal case where an absolute PGDATA path is used, but quite dangerous if a relative path is specified, since the program might then fail to notice an active postmaster. Reported by Hari Babu. This got broken in my commit eb5949d, so patch all active versions.
diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -87,7 +87,6 @@ main(int argc, char *argv[])
 	char	   *endptr3;
 	char	   *DataDir;
 	int			fd;
-	char		path[MAXPGPATH];
 
 	set_pglocale_pgservice(argv[0], "pg_resetxlog");
 
@@ -262,21 +261,20 @@ main(int argc, char *argv[])
 	 * Check for a postmaster lock file --- if there is one, refuse to
 	 * proceed, on grounds we might be interfering with a live installation.
 	 */
-	snprintf(path, MAXPGPATH, "%s/postmaster.pid", DataDir);
-
-	if ((fd = open(path, O_RDONLY, 0)) < 0)
+	if ((fd = open("postmaster.pid", O_RDONLY, 0)) < 0)
 	{
 		if (errno != ENOENT)
 		{
-			fprintf(stderr, _("%s: could not open file \"%s\" for reading: %s\n"), progname, path, strerror(errno));
+			fprintf(stderr, _("%s: could not open file \"%s\" for reading: %s\n"),
+					progname, "postmaster.pid", strerror(errno));
 			exit(1);
 		}
 	}
 	else
 	{
 		fprintf(stderr, _("%s: lock file \"%s\" exists\n"
 						  "Is a server running?  If not, delete the lock file and try again.\n"),
-				progname, path);
+				progname, "postmaster.pid");
 		exit(1);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,6 @@ main(int argc, char *argv[])`
`87`	`87`	`char *endptr3;`
`88`	`88`	`char *DataDir;`
`89`	`89`	`int fd;`
`90`		`- char path[MAXPGPATH];`
`91`	`90`
`92`	`91`	`set_pglocale_pgservice(argv[0], "pg_resetxlog");`
`93`	`92`
`@@ -262,21 +261,20 @@ main(int argc, char *argv[])`
`262`	`261`	`* Check for a postmaster lock file --- if there is one, refuse to`
`263`	`262`	`* proceed, on grounds we might be interfering with a live installation.`
`264`	`263`	`*/`
`265`		`- snprintf(path, MAXPGPATH, "%s/postmaster.pid", DataDir);`
`266`		`-`
`267`		`- if ((fd = open(path, O_RDONLY, 0)) < 0)`
	`264`	`+ if ((fd = open("postmaster.pid", O_RDONLY, 0)) < 0)`
`268`	`265`	`{`
`269`	`266`	`if (errno != ENOENT)`
`270`	`267`	`{`
`271`		`- fprintf(stderr, _("%s: could not open file \"%s\" for reading: %s\n"), progname, path, strerror(errno));`
	`268`	`+ fprintf(stderr, _("%s: could not open file \"%s\" for reading: %s\n"),`
	`269`	`+ progname, "postmaster.pid", strerror(errno));`
`272`	`270`	`exit(1);`
`273`	`271`	`}`
`274`	`272`	`}`
`275`	`273`	`else`
`276`	`274`	`{`
`277`	`275`	`fprintf(stderr, _("%s: lock file \"%s\" exists\n"`
`278`	`276`	`"Is a server running? If not, delete the lock file and try again.\n"),`
`279`		`- progname, path);`
	`277`	`+ progname, "postmaster.pid");`
`280`	`278`	`exit(1);`
`281`	`279`	`}`
`282`	`280`