E532 fix(templates-no-negated-async): not reporting failures for some cases by rafaelss95 · Pull Request #694 · mgechev/codelyzer · GitHub
[go: up one dir, main page]
Skip to content

fix(templates-no-negated-async): not reporting failures for some cases#694

Merged
mgechev merged 1 commit intomgechev:masterfrom
rafaelss95:fix-templates-no-negated-async
Jul 29, 2018
Merged

fix(templates-no-negated-async): not reporting failures for some cases#694
mgechev merged 1 commit intomgechev:masterfrom
rafaelss95:fix-templates-no-negated-async

Conversation

@rafaelss95
Copy link
Collaborator
@rafaelss95 rafaelss95 commented Jul 29, 2018

Relates to #615, it:

  • Remove hasFix option (code and tests were updated as well);
  • Fixes all the cases described in the issue above;

About deprecate/drop this rule, I'll do another PR once I'm allowed to do so.

@rafaelss95 rafaelss95 requested a review from mgechev July 29, 2018 19:14
mgechev
mgechev approved these changes Jul 29, 2018
View reviewed changes
Copy link
Owner
@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgechev mgechev merged commit 2ffe2ea into mgechev:master Jul 29, 2018
@rafaelss95 rafaelss95 deleted the fix-templates-no-negated-async branch July 29, 2018 21:38
@mgechev mgechev added this to the Tony Hoare milestone Aug 2, 2018
@snyk-bot snyk-bot mentioned this pull request Oct 12, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgechev mgechev mgechev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Tony Hoare