8000 Merge pull request #71 from hoefling/master · mgaitan/sphinxcontrib-mermaid@cb44181 · GitHub
[go: up one dir, main page]

Skip to content

Commit cb44181

Browse files
authored
Merge pull request #71 from hoefling/master
Adapt to upcoming Sphinx==4.0 release
2 parents 07f9d43 + 4e08a6e commit cb44181

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

sphinxcontrib/mermaid.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import sphinx
2525
from sphinx.locale import _
2626
from sphinx.util.i18n import search_image_for_language
27-
from sphinx.util.osutil import ensuredir, ENOENT
27+
from sphinx.util.osutil import ensuredir
2828
from sphinx.util import logging
2929
from .exceptions import MermaidError
3030
from .autoclassdiag import class_diagram
@@ -173,9 +173,7 @@ def render_mm(self, code, options, _fmt, prefix='mermaid'):
173173

174174
try:
175175
p = Popen(mm_args, shell=mermaid_cmd_shell, stdout=PIPE, stdin=PIPE, stderr=PIPE)
176-
except OSError as err:
177-
if err.errno != ENOENT: # No such file or directory
178-
raise
176+
except FileNotFoundError:
179177
logger.warning('command %r cannot be run (needed for mermaid '
180178
'output), check the mermaid_cmd setting' % mermaid_cmd)
181179
return None, None

tests/test_html.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,14 @@ def build_all(app):
77

88
@pytest.fixture
99
def index(app, build_all):
10-
return (app.outdir / 'index.html').read_text()
10+
# normalize script tag for compat to Sphinx<4
11+
return (app.outdir / 'index.html').read_text().replace("<script >", "<script>")
1112

1213

1314
@pytest.mark.sphinx('html', testroot="basic")
1415
def test_html_raw(index):
1516
assert '<script src="https://unpkg.com/mermaid/dist/mermaid.min.js"></script>' in index
16-
assert "<script >mermaid.initialize({startOnLoad:true});</script>" in index
17+
assert "<script>mermaid.initialize({startOnLoad:true});</script>" in index
1718
assert """<div class="mermaid">
1819
sequenceDiagram
1920
participant Alice
@@ -36,14 +37,14 @@ def test_conf_mermaid_no_version(app, index):
3637

3738
@pytest.mark.sphinx('html', testroot="basic", confoverrides={'mermaid_init_js': "custom script;"})
3839
def test_mermaid_init_js(index):
39-
assert "<script >mermaid.initialize({startOnLoad:true});</script>" not in index
40-
assert '<script >custom script;</script>' in index
40+
assert "<script>mermaid.initialize({startOnLoad:true});</script>" not in index
41+
assert '<script>custom script;</script>' in index
4142

4243

4344
@pytest.mark.sphinx('html', testroot="markdown")
4445
def test_html_raw_from_markdown(index):
4546
assert '<script src="https://unpkg.com/mermaid/dist/mermaid.min.js"></script>' in index
46-
assert "<script >mermaid.initialize({startOnLoad:true});</script>" in index
47+
assert "<script>mermaid.initialize({startOnLoad:true});</script>" in index
4748
assert """
4849
<div class="mermaid">
4950
sequenceDiagram

0 commit comments

Comments
 (0)
0