fix KeyError when server reports unknown collation

methane · methane · commit 7af477b1abaa · 2017-08-21T21:40:09.000+09:00
fixes PyMySQL#591
diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
@@ -1,3 +1,5 @@
+**IF YOU HAVE SOME TROUBLE, IT'S MAY NOT ISSUE OF THIS PROJECT. GO STACKOVERFLOW!!!**
+
 This project is maintained one busy person with a frail wife and an infant daughter.
 My time and energy is a very limited resource. I'm not a teacher or free tech support.
 Don't ask a question here.  Don't file an issue until you believe it's a not a problem with your code.
diff --git a/pymysql/connections.py b/pymysql/connections.py
@@ -1266,8 +1266,14 @@ def _get_server_information(self):
         if len(data) >= i + 6:
             lang, stat, cap_h, salt_len = struct.unpack('<BHHB', data[i:i+6])
             i += 6
+            # TODO: deprecate server_language and server_charset.
+            # mysqlclient-python doesn't provide it.
             self.server_language = lang
-            self.server_charset = charset_by_id(lang).name
+            try:
+                self.server_charset = charset_by_id(lang).name
+            except KeyError:
+                # unknown collation
+                self.server_charset = None
 
             self.server_status = stat
             if DEBUG: print("server_status: %x" % stat)

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+IF YOU HAVE SOME TROUBLE, IT'S MAY NOT ISSUE OF THIS PROJECT. GO STACKOVERFLOW!!!`
	`2`	`+`
`1`	`3`	`This project is maintained one busy person with a frail wife and an infant daughter.`
`2`	`4`	`My time and energy is a very limited resource. I'm not a teacher or free tech support.`
`3`	`5`	`Don't ask a question here. Don't file an issue until you believe it's a not a problem with your code.`