pythongh-119011: Return an empty tuple on type_get_type_params as special case for PyType_Type

mdkcore0 · mdkcore0 · commit 65ae07b8f462 · 2024-05-21T11:53:26.000-03:00
diff --git a/Misc/NEWS.d/next/Core and Builtins/2024-05-21-11-51-54.gh-issue-119011.Ja5dwc.rst b/Misc/NEWS.d/next/Core and Builtins/2024-05-21-11-51-54.gh-issue-119011.Ja5dwc.rst
@@ -0,0 +1,2 @@
+This fixes an issue with ``functools.update_wrapper`` where it was not
+returning a tuple for ``__type_params__`` as expected.
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
@@ -1743,7 +1743,7 @@ static PyObject *
 type_get_type_params(PyTypeObject *type, void *context)
 {
     PyObject *params;
-    if (PyDict_GetItemRef(lookup_tp_dict(type), &_Py_ID(__type_params__), &params) == 0) {
+    if (type == &PyType_Type || PyDict_GetItemRef(lookup_tp_dict(type), &_Py_ID(__type_params__), &params) == 0) {
         return PyTuple_New(0);
     }
     return params;

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+This fixes an issue with ``functools.update_wrapper`` where it was not
	`2`	+returning a tuple for ``__type_params__`` as expected.
Original file line number	Diff line number	Diff line change
`@@ -1743,7 +1743,7 @@ static PyObject *`
`1743`	`1743`	`type_get_type_params(PyTypeObject type, void context)`
`1744`	`1744`	`{`
`1745`	`1745`	`PyObject *params;`
`1746`		`- if (PyDict_GetItemRef(lookup_tp_dict(type), &_Py_ID(__type_params__), &params) == 0) {`
	`1746`	`+ if (type == &PyType_Type \|\| PyDict_GetItemRef(lookup_tp_dict(type), &_Py_ID(__type_params__), &params) == 0) {`
`1747`	`1747`	`return PyTuple_New(0);`
`1748`	`1748`	`}`
`1749`	`1749`	`return params;`