ds1307: Return error code instead of boolean

Dmitry Salychev · Dmitry Salychev · commit 645a228481c7 · 2024-06-03T15:41:11.000+02:00
It's probably a copy-paste leftover from the other functions which
return a boolean value and generates annoying "CLOCK_SETTIME error 1"
from subr_rtc.c on Traverse Ten64 in verbose mode.

No functional changes intended.

MFC after:	3 days
diff --git a/sys/dev/iicbus/rtc/ds1307.c b/sys/dev/iicbus/rtc/ds1307.c
@@ -346,7 +346,7 @@ mark_epson_time_valid(struct ds1307_softc *sc)
 	if (error) {
 		device_printf(dev, "%s cannot read Control 2 register: %d\n",
 		    __func__, error);
-		return (false);
+		return (error);
 	}
 
 	control_mask = (RX8035_CTRL_2_PON | RX8035_CTRL_2_XSTP | RX8035_CTRL_2_VDET);
@@ -356,9 +356,9 @@ mark_epson_time_valid(struct ds1307_softc *sc)
 	if (error) {
 		device_printf(dev, "%s cannot write to Control 2 register: %d\n",
 		    __func__, error);
-		return (false);
+		return (error);
 	}
-	return (true);
+	return (0);
 }
 
 static bool is_dev_time_valid(struct ds1307_softc *sc)

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,7 @@ mark_epson_time_valid(struct ds1307_softc *sc)`
`346`	`346`	`if (error) {`
`347`	`347`	`device_printf(dev, "%s cannot read Control 2 register: %d\n",`
`348`	`348`	`__func__, error);`
	`- return (false);`
	`349`	`+ return (error);`
`350`	`350`	`}`
`351`	`351`
`352`	`352`	`control_mask = (RX8035_CTRL_2_PON \| RX8035_CTRL_2_XSTP \| RX8035_CTRL_2_VDET);`
`@@ -356,9 +356,9 @@ mark_epson_time_valid(struct ds1307_softc *sc)`
`356`	`356`	`if (error) {`
`357`	`357`	`device_printf(dev, "%s cannot write to Control 2 register: %d\n",`
`358`	`358`	`__func__, error);`
`359`		`- return (false);`
	`359`	`+ return (error);`
`360`	`360`	`}`
`361`		`- return (true);`
	`361`	`+ return (0);`
`362`	`362`	`}`
`363`	`363`
`364`	`364`	`static bool is_dev_time_valid(struct ds1307_softc *sc)`