8000 test(browser-integration-tests): Check for full equality in error eve… · mcous/sentry-javascript@d943cce · GitHub
[go: up one dir, main page]
Skip to content

Commit d943cce

Browse files
Lms24Lms24
authored
test(browser-integration-tests): Check for full equality in error event trace context (getsentry#11681)
More clearly shows the current difference in `event.contexts.trace` for error events, depending on if they were sent during an active span or afterwards.
1 parent b05bfd9 commit d943cce

File tree

3 files changed

+26
-4
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/trace-lifetime

3 files changed

+26
-4
lines changed

‎dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/navigation/test.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,15 @@ sentryTest('error during navigation has new navigation traceId', async ({ getLoc
160160
});
161161

162162
const errorTraceContext = errorEvent?.contexts?.trace;
163-
expect(errorTraceContext).toMatchObject({
163+
expect(errorTraceContext).toEqual({
164+
data: {
165+
'sentry.op': 'navigation',
166+
'sentry.origin': 'auto.navigation.browser',
167+
'sentry.sample_rate': 1,
168+
'sentry.source': 'url',
169+
},
164170
op: 'navigation',
171+
origin: 'auto.navigation.browser',
165172
trace_id: navigationTraceContext?.trace_id,
166173
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
167174
});

‎dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload-meta/test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ sentryTest('error after <meta> tag pageload has pageload traceId', async ({ getL
111111
await page.locator('#errorBtn').click();
112112
const [errorEvent, errorTraceHeader] = await errorEventPromise;
113113

114-
expect(errorEvent.contexts?.trace).toMatchObject({
114+
expect(errorEvent.contexts?.trace).toEqual({
115115
trace_id: META_TAG_TRACE_ID,
116116
parent_span_id: META_TAG_PARENT_SPAN_ID,
117117
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
@@ -167,7 +167,15 @@ sentryTest('error during <meta> tag pageload has pageload traceId', async ({ get
167167
trace_id: META_TAG_TRACE_ID,
168168
});
169169

170-
expect(errorEvent?.contexts?.trace).toMatchObject({
170+
expect(errorEvent?.contexts?.trace).toEqual({
171+
data: {
172+
'sentry.op': 'pageload',
173+
'sentry.origin': 'auto.pageload.browser',
174+
'sentry.sample_rate': 1,
175+
'sentry.source': 'url',
176+
},
177+
op: 'pageload',
178+
origin: 'auto.pageload.browser',
171179
trace_id: META_TAG_TRACE_ID,
172180
parent_span_id: META_TAG_PARENT_SPAN_ID,
173181
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),

‎dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload/test.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,15 @@ sentryTest('error during pageload has pageload traceId', async ({ getLocalTestPa
157157
});
158158

159159
const errorTraceContext = errorEvent?.contexts?.trace;
160-
expect(errorTraceContext).toMatchObject({
160+
expect(errorTraceContext).toEqual({
161+
data: {
162+
'sentry.op': 'pageload',
163+
'sentry.origin': 'auto.pageload.browser',
164+
'sentry.sample_rate': 1,
165+
'sentry.source': 'url',
166+
},
161167
op: 'pageload',
168+
origin: 'auto.pageload.browser',
162169
trace_id: pageloadTraceContext?.trace_id,
163170
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
164171
});

0 commit comments

Comments
 (0)
0