8000 Fix release script consistency issues · maxmind/GeoIP2-python@18ed735 · GitHub
[go: up one dir, main page]

Skip to content

Commit 18ed735

Browse files
committed
Fix release script consistency issues
- Remove redundant git push --tags (gh release create handles tags) - Fix shellcheck SC2162: add -r flag to read command - Apply shfmt formatting
1 parent b22afdb commit 18ed735

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

dev-bin/release.sh

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,26 @@ set -eu -o pipefail
66
# before making any changes to the repository
77

88
check_command() {
9-
if ! command -v "$1" &> /dev/null; then
9+
if ! command -v "$1" &>/dev/null; then
1010
echo "Error: $1 is not installed or not in PATH"
1111
exit 1
1212
fi
1313
}
1414

1515
# Verify gh CLI is authenticated
16-
if ! gh auth status &> /dev/null; then
16+
if ! gh auth status &>/dev/null; then
1717
echo "Error: gh CLI is not authenticated. Run 'gh auth login' first."
1818
exit 1
1919
fi
2020

2121
# Verify we can access this repository via gh
22-
if ! gh repo view --json name &> /dev/null; then
22+
if ! gh repo view --json name &>/dev/null; then
2323
echo "Error: Cannot access repository via gh. Check your authentication and repository access."
2424
exit 1
2525
fi
2626

2727
# Verify git can connect to the remote (catches SSH key issues, etc.)
28-
if ! git ls-remote origin &> /dev/null; then
28+
if ! git ls-remote origin &>/dev/null; then
2929
echo "Error: Cannot connect to git remote. Check your git credentials/SSH keys."
3030
exit 1
3131
fi
@@ -62,8 +62,8 @@ regex='
6262
'
6363

6464
if [[ ! $changelog =~ $regex ]]; then
65-
echo "Could not find date line in change log!"
66-
exit 1
65+
echo "Could not find date line in change log!"
66+
exit 1
6767
fi
6868

6969
version="${BASH_REMATCH[1]}"
@@ -93,7 +93,7 @@ git diff
9393
echo $'\nRelease notes:'
9494
echo "$notes"
9595

96-
read -e -p "Commit changes and push to origin? " should_push
96+
read -r -e -p "Commit changes and push to origin? " should_push
9797

9898
if [ "$should_push" != "y" ]; then
9999
echo "Aborting"
@@ -105,5 +105,3 @@ git commit -m "Update for $tag" -a
105105
git push
106106

107107
gh release create --target "$(git branch --show-current)" -t "$version" -n "$notes" "$tag"
108-
109-
git push --tags

0 commit comments

Comments
 (0)
0