fix: add format() calls to glob_exclude templates (bazel-contrib#1285)

lpulley · web-flow · commit 4082693e23ec · 2023-07-06T14:54:43.000Z
Currently, Python toolchain `:files` and `:py3_runtime` include some unnecessary files. This is because these globs result in literally `lib/libpython{python_version}.so` etc., which do not match anything. The formatting needs to be applied here since it will not be applied later. I believe this was introduced by a47c6cd.
diff --git a/python/repositories.bzl b/python/repositories.bzl
@@ -204,12 +204,12 @@ def _python_repository_impl(rctx):
         "**/* *",  # Bazel does not support spaces in file names.
         # Unused shared libraries. `python` executable and the `:libpython` target
         # depend on `libpython{python_version}.so.1.0`.
-        "lib/libpython{python_version}.so",
+        "lib/libpython{python_version}.so".format(python_version = python_short_version),
         # static libraries
         "lib/**/*.a",
         # tests for the standard libraries.
-        "lib/python{python_version}/**/test/**",
-        "lib/python{python_version}/**/tests/**",
+        "lib/python{python_version}/**/test/**".format(python_version = python_short_version),
+        "lib/python{python_version}/**/tests/**".format(python_version = python_short_version),
     ]
 
     if rctx.attr.ignore_root_user_error:
