8000 Add performance warnings for packing args tuple · mattip/numpy@1b79fc8 · GitHub
[go: up one dir, main page]
Skip 8000 to content

Commit 1b79fc8

Browse files
fangererfangerer
committed
Add performance warnings for packing args tuple
1 parent 868ee22 commit 1b79fc8

File tree

11 files changed

+21
-0
lines changed

11 files changed

+21
-0
lines changed

‎numpy/core/src/multiarray/arrayfunction_override.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,7 @@ hpy_call_array_function(HPyContext *ctx, HPy argument, HPy method,
380380
return hpy_array_function_method_impl(ctx, public_api, types, args, kwargs);
381381
}
382382
else {
383+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
383384
HPy args_tuple = HPyTuple_Pack(ctx, 5, argument, public_api, types, args, kwargs);
384385
HPy ret = HPy_CallTupleDict(ctx, method, args_tuple, HPy_NULL);
385386
HPy_Close(ctx, args_tuple);

‎numpy/core/src/multiarray/arrayobject.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1620,6 +1620,7 @@ _void_compare(HPyContext *ctx,
16201620
res = temp;
16211621
}
16221622
else {
1623+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
16231624
HPy args = HPyTuple_Pack(ctx, 2, res, temp);
16241625
temp2 = HPy_CallTupleDict(ctx, op, args, HPy_NULL);
16251626
HPy_Close(ctx, args);

‎numpy/core/src/multiarray/common.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,7 @@ hpy_check_and_adjust_axis_msg(HPyContext *ctx, int *axis, int ndim, HPy msg_pref
279279
}
280280

281281
/* Invoke the AxisError constructor */
282+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
282283
HPy args = HPy_BuildValue(ctx, "iiO", *axis, ndim, msg_prefix);
283284
exc = HPy_CallTupleDict(ctx, AxisError_cls, args, HPy_NULL);
284285
if (HPy_IsNull(exc)) {

‎numpy/core/src/multiarray/ctors.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,6 +1211,7 @@ HPyArray_NewFromDescr_int(
12111211
arg = HPy_Dup(ctx, h_obj);
12121212
}
12131213
// result, arg
1214+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
12141215
HPy args = HPyTuple_Pack(ctx, 2, result, arg);
12151216
HPy res = HPy_CallTupleDict(ctx, func, args, HPy_NULL);
12161217

‎numpy/core/src/multiarray/datetime.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2651,6 +2651,7 @@ hpy_convert_pydatetime_to_datetimestruct(HPyContext *ctx, HPy obj, npy_datetimes
26512651
/* The utcoffset function should return a timedelta */
26522652
HPy tmp_type = HPy_Type(ctx, tmp);
26532653
HPy utcoffset = HPy_GetAttr_s(ctx, tmp_type, "utcoffset");
2654+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
26542655
HPy args = HPyTuple_Pack(ctx, 1, obj);
26552656
offset = HPy_CallTupleDict(ctx, utcoffset, args, HPy_NULL);
26562657
HPy_Close(ctx, tmp_type);
@@ -2769,6 +2770,7 @@ hpy_get_tzoffset_from_pytzinfo(HPyContext *ctx, HPy timezone_obj, npy_datetimest
27692770
/* Convert the datetime from UTC to local time */
27702771
HPy obj_type = HPy_Type(ctx, timezone_obj);
27712772
HPy fromutc = HPy_GetAttr_s(ctx, obj_type, "fromutc");
2773+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
27722774
HPy args = HPyTuple_Pack(ctx, 1, dt);
27732775
loc_dt = HPy_CallTupleDict(ctx, fromutc, args, HPy_NULL);
27742776
HPy_Close(ctx, obj_type);

‎numpy/core/src/multiarray/descriptor.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ _hpy_try_c 628C onvert_from_ctypes_type(HPyContext *ctx, HPy /* PyTypeObject * */ type
6969
if (HPy_IsNull(_numpy_dtype_ctypes)) {
7070
return HPy_NULL;
7171
}
72+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
7273
HPy args = HPyTuple_Pack(ctx, 1, type);
7374
HPy meth = HPy_GetAttr_s(ctx, _numpy_dtype_ctypes, "dtype_from_ctypes_type");
7475
res = HPy_CallTupleDict(ctx, meth, args, HPy_NULL);
@@ -827,6 +828,7 @@ _hpy_convert_from_commastring(HPyContext *ctx, HPy obj, int align)
827828
if (HPy_IsNull(_numpy_internal)) {
828829
return HPy_NULL;
829830
}
831+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
830832
HPy args = HPyTuple_Pack(ctx, 1, obj);
831833
HPy meth = HPy_GetAttr_s(ctx, _numpy_internal, "_commastring");
832834
HPy listobj = HPy_CallTupleDict(ctx, meth, args, HPy_NULL);
@@ -1164,6 +1166,7 @@ _hpy_convert_from_field_dict(HPyContext *ctx, HPy obj, int align)
11641166
return HPy_NULL;
11651167
}
11661168
HPy h_align = HPyLong_FromLong(ctx, align);
1169+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
11671170
HPy args = HPyTuple_Pack(ctx, 2, obj, h_align);
11681171
HPy_Close(ctx, h_align);
11691172
HPy meth = HPy_GetAttr_s(ctx, _numpy_internal, "_usefields");
@@ -2207,6 +2210,7 @@ arraydescr_name_get(HPyContext *ctx, HPy /* PyArray_Descr * */ self, void *NPY_U
22072210
return HPy_NULL;
22082211
}
22092212

2213+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
22102214
args = HPyTuple_Pack(ctx, 1, self);
22112215
meth = HPy_GetAttr_s(ctx, _numpy_dtype, "_name_get");
22122216
res = HPy_CallTupleDict(ctx, meth, args, HPy_NULL);
@@ -2297,6 +2301,7 @@ arraydescr_descr_get(HPyContext *ctx, HPy /* PyArray_Descr * */ self, void *NPY_
22972301
if (HPy_IsNull(_numpy_internal)) {
22982302
return HPy_NULL;
22992303
}
2304+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
23002305
args = HPyTuple_Pack(ctx, 1, self);
23012306
meth = HPy_GetAttr_s(ctx, _numpy_internal, "_array_descr");
23022307
res = HPy_CallTupleDict(ctx, meth, args, HPy_NULL);
@@ -3765,6 +3770,7 @@ arraydescr_repr_impl(HPyContext *ctx, HPy dtype)
37653770
if (HPy_IsNull(_numpy_dtype)) {
37663771
return HPy_NULL;
37673772
}
3773+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
37683774
HPy args = HPyTuple_Pack(ctx, 1, dtype);
37693775
HPy meth = HPy_GetAttr_s(ctx, _numpy_dtype, "__repr__");
37703776
res = HPy_CallTupleDict(ctx, meth, args, HPy_NULL);
@@ -4041,6 +4047,7 @@ harraydescr_field_subset_view(HPyContext *ctx,
40414047
HPy fmt = HPyUnicode_FromString(ctx,
40424048
"duplicate field of name {!r}");
40434049
if (!HPy_IsNull(fmt)) {
4050+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
40444051
HPy args = HPyTuple_Pack(ctx, 1, name);
40454052
HPy h_format = HPy_GetAttr_s(ctx, fmt, "format");
40464053
msg = HPy_CallTupleDict(ctx, h_format, args, HPy_NULL);

‎numpy/core/src/multiarray/dlpack.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,7 @@ NPY_NO_EXPORT HPy
294294
_from_dlpack_impl(HPyContext *ctx, HPy NPY_UNUSED(self), HPy obj) {
295295
HPy obj_type = HPy_Type(ctx, obj);
296296
HPy __dlpack__ = HPy_GetAttr_s(ctx, obj_type, "__dlpack__");
297+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
297298
HPy args = HPyTuple_Pack(ctx, 1, obj);
298299
HPy capsule = HPy_CallTupleDict(ctx, __dlpack__, args, HPy_NULL);
299300
HPy_Close(ctx, obj_type);

‎numpy/core/src/multiarray/flagsobject.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,7 @@ arrayflags_writebackifcopy_set(
475475
"Cannot set flags on array scalars.");
476476
return -1;
477477
}
478+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
478479
h_args = HPyTuple_Pack(ctx, 3,
479480
ctx->h_None,
480481
ctx->h_None,
@@ -514,6 +515,7 @@ arrayflags_aligned_set(
514515
"Cannot set flags on array scalars.");
515516
return -1;
516517
}
518+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
517519
h_args = HPyTuple_Pack(ctx, 3,
518520
ctx->h_None,
519521
HPy_IsTrue(ctx, obj) ? ctx->h_True : ctx->h_False,
@@ -554,6 +556,7 @@ arrayflags_writeable_set(
554556
"Cannot set flags on array scalars.");
555557
return -1;
556558
}
559+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
557560
h_args = HPyTuple_Pack(ctx, 3, HPy_IsTrue(ctx, obj) ? ctx->h_True : ctx->h_False, ctx->h_None, ctx->h_None);
558561
h_setflags = HPy_GetAttr_s(ctx, h_arr, "setflags");
559562
res = HPy_CallTupleDict(ctx, h_setflags, h_args, HPy_NULL);

‎numpy/core/src/multiarray/getset.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ array_ctypes_get(HPyContext *ctx, HPy /*PyArrayObject*/ h_self, void *NPY_UNUSED
291291
return HPy_NULL;
292292
}
293293
PyArrayObject *self = PyArrayObject_AsStruct(ctx, h_self);
294+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
294295
HPy args = HPyTuple_Pack(ctx, 2, h_self,
295296
HPyLong_FromVoidPtr(ctx, PyArray_DATA(self)));
296297
HPy meth = HPy_GetAttr_s(ctx, _numpy_internal, "_ctypes");
@@ -537,6 +538,7 @@ array_descr_dtype_set(HPyContext *ctx, HPy /* PyArrayObject * */ self, HPy arg,
537538
if (HPy_IsNull(checkfunc)) {
538539
goto fail;
539540
}
541+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
540542
HPy args = HPyTuple_Pack(ctx, 2, self_descr, newtype);
541543
safe = HPy_CallTupleDict(ctx, checkfunc, args, HPy_NULL);
542544
HPy_Close(ctx, args);

‎numpy/core/src/multiarray/number.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,7 @@ HPyArray_GenericReduceFunction(HPyContext *ctx,
277277
HPy args, ret = HPy_NULL, meth;
278278
HPy kwds;
279279

280+
HPY_PERFORMANCE_WARNING("packing args for HPy_CallTupleDict");
280281
args = HPy_BuildValue(ctx, "(Oi)", m1, axis);
281282
kwds = _hpy_get_keywords(ctx, rtype, out);
282283
meth = HPy_GetAttr_s(ctx, op, "reduce");

0 commit comments

Comments
 (0)
0