This repository was archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Copy link
Copy link
Open
Labels
O-UncommonMost users are unlikely to come across this or unexpected workflowMost users are unlikely to come across this or unexpected workflowS-TolerableMinor significance, cosmetic issues, low or no impact to users.Minor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.good first issueGood for newcomersGood for newcomers
Description
Description
There are a handful of places left that use the deprecated cmp
argument on the attr.s
decorator:
synapse/synapse/events/builder.py
Line 38 in 0a00b7f
@attr.s(slots=True, cmp=False, frozen=True) Line 472 in d29b71a
@attr.s(cmp=False) Line 421 in a7a3790
@attr.s(frozen=True, slots=True, cmp=False) synapse/synapse/crypto/keyring.py
Line 65 in 31b1905
@attr.s(slots=True, cmp=False)
These should be fixed.
Metadata
Metadata
Assignees
Labels
O-UncommonMost users are unlikely to come across this or unexpected workflowMost users are unlikely to come across this or unexpected workflowS-TolerableMinor significance, cosmetic issues, low or no impact to users.Minor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.good first issueGood for newcomersGood for newcomers