Cleanup examples and re-enable pep8 #8603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try and use `plt.subplots` more and remove extraneous `plt.draw`.
* E402 module level import not at top of file - Tutorials repeat themselves a bit so are likely to show imports more than once. * E501 line too long (82 > 79 characters) - Already ignored for examples and this is already a problem for many lines in the existing text.
This should make pep8 checks work again since all of the source directory will be touched. Also, make the test script verbose so it prints out what it's doing (this is part of the recommendations from Travis.)
|
6690 passed, 6 skipped, 6 xfailed, 9 xpassed == 6711 tests on the 2.7 build |
dstansby
approved these changes
May 12, 2017
|
Thanks for the detailed work @QuLogic ! |
|
This is great, nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PEP8 has not been running for a while, so fix the examples and do a bit of minor cleanup. Most of the PEP8 stuff is just deleting or adding blank lines. For the cleanup, I tried to use
plt.subplotsa bit more often in the examples that were updated.The reason why so many examples are suddenly failing is that a whole directory was moved out of
docstoexamplesand docs are pep8-exempt.For the
tutorialsdirectory, I've allowedE402andE501; these are already exempted for theexamplesdirectory and there are already very many long lines, so "fixing" this would cause a lot of churn and in some cases (tables, URLs, mostly) appear rather ugly.Fixes #8498.
PR Checklist