regression on v1.1.x branch, doc build deadlocks #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If using a recursive lock fixes the problem, could you make a pull request with that, please? (I know nothing of the threading lock stuff...) |
|
FYI: I'm able to reproduce the deadlock here. Trying with a recursive lock now... |
|
Indeed, that resolves the issue... |
|
@juliantaylor: Can you confirm the attached PR works for you? I'd like to somewhat fast-track this fix since it's so important. |
8000
|
yes the PR fixes the issue. |
mdboom
added a commit
that referenced
this pull request
Apr 27, 2012
regression on v1.1.x branch, doc build deadlocks
|
fyi. ubuntu 12.04 has released with a snapshot from the v1.1.x branch including this fix. Should serious issues come up it will be upgraded to 1.1.1 final. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5B2F
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since commit a00e510 (use threading Lock to protect class level font cache) the doc build deadlocks on 91% faq/how_to on an ubuntu 12.04 system
reverting only that commit fixes the issue
Using a recursive lock fixes it too.